Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update streaming subscription to understand new initial response #601

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

JoshVanL
Copy link
Contributor

Description

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: joshvanl <me@joshvanl.dev>
@JoshVanL JoshVanL requested review from a team as code owners July 23, 2024 11:03
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 61.61%. Comparing base (27248ba) to head (1697890).
Report is 24 commits behind head on main.

Files Patch % Lines
client/subscribe.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   58.04%   61.61%   +3.56%     
==========================================
  Files          55       56       +1     
  Lines        3568     3436     -132     
==========================================
+ Hits         2071     2117      +46     
+ Misses       1375     1193     -182     
- Partials      122      126       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions for the workflow

.github/workflows/validate_examples.yaml Outdated Show resolved Hide resolved
.github/workflows/validate_examples.yaml Outdated Show resolved Hide resolved
.github/workflows/validate_examples.yaml Outdated Show resolved Hide resolved
Co-authored-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: Josh van Leeuwen <me@joshvanl.dev>
@JoshVanL
Copy link
Contributor Author

@mikeee done

@yaron2 yaron2 merged commit 9bc7d82 into dapr:main Jul 23, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants