Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: holopin formatting #166

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: holopin formatting #166

merged 1 commit into from
Apr 11, 2024

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Apr 11, 2024

Description

I believe this is a formatting issue. Updating the holopin badge

Issue reference

This PR is linked to #164

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Mike Nguyen <hey@mike.ee>
@mikeee mikeee requested review from a team as code owners April 11, 2024 08:20
@mikeee mikeee merged commit 396f571 into main Apr 11, 2024
5 of 6 checks passed
@mikeee mikeee deleted the holopin-update branch April 11, 2024 08:20
@KentHsu
Copy link
Contributor

KentHsu commented Apr 11, 2024

Hi @mikeee,
Sorry I didn't notice the formatting but I found this PR in go-sdk has the same issue.
Hope we can avoid the same mistake there.

@mikeee
Copy link
Member Author

mikeee commented Apr 11, 2024

I'm not sure if it matters with yaml, I think I'm unable to issue stickers as I'm not part of the holopin org 👍

@marcduiker
Copy link
Contributor

The formatting is not an issue. See the Holopin bot readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants