Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use simple_x509 to generate webrtc self-signed cert #219

Merged
merged 6 commits into from
May 13, 2024

Conversation

dariusc93
Copy link
Owner

@dariusc93 dariusc93 commented May 13, 2024

Due to rcgen using ring rng when signing the certificate and the lack of an API to seed the rng, we are not able to properly generate deterministic certificates utilizing ring. Originally, exposing the api to generate the certificate by the end-user so they could eventually pass that same certificate back internally was the idea to get around this, however this may not be a preferred option long term since this requires the node to store the certificate and keypair generated.

This PR introduce a change to use simple_x509 to generate the certificate instead of rcgen, which would allow us to use the ecdsa keypair to sign the certificate instead, which would allow us to produce a deterministic certificate.

Relates to libp2p/rust-libp2p#3049

Note:

@dariusc93 dariusc93 self-assigned this May 13, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@dariusc93 dariusc93 marked this pull request as ready for review May 13, 2024 23:49
@dariusc93 dariusc93 merged commit 4302b78 into libp2p-next May 13, 2024
@dariusc93 dariusc93 deleted the chore/wrtc-cert branch May 13, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant