-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shut down all children on SIGTERM #39
Comments
Hey @etianen thanks for the issue. It sounds like a bug. PRs welcome to fix it 😉 |
Out of interest, why does parellelshell choose to terminate child processes I think the correct behaviour here is to listen for both SIGINT and On Mon, 19 Oct 2015 at 09:54 Keith Cirkel notifications@github.com wrote:
|
SIGINT is used when a terminal sends Ctrl+C. We close apps down because that's what you'd expect from sending Ctrl+C. I guess we should probably send all signals to the respective processes though, as you suggest. FYI, if you submit a PR to this code, you should know that mysticatea/npm-run-all#10 exists and that parallelshell may be deprecated soon, in favour of consolidating it with other libs (see mysticatea/npm-run-all#10 for more). While I'm happy to release new versions in the interim - this is the end goal of parallelshell (to be subsumed/consumed into npm-run-all). |
Hmm, I see, thanks for the heads up! I'm not sure I'll bother with the PR, in that case. I've been using On Mon, 19 Oct 2015 at 10:11 Keith Cirkel notifications@github.com wrote:
|
I see that parallelshell responds to the SIGINT signal by cleanly shutting down all it's children.
However, when stopped with the SIGTERM signal it simply exits, leaving all it's spawned children running.
Is this intentional behaviour?
The text was updated successfully, but these errors were encountered: