-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reformat
tweak
#197
base: main
Are you sure you want to change the base?
Add reformat
tweak
#197
Conversation
PR HealthPackage publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. License Headers ✔️Details
All source files should start with a license header. Coverage
|
File | Coverage |
---|---|
pkgs/firehose/lib/firehose.dart | 💔 Not covered |
pkgs/firehose/lib/src/health/health.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
Breaking changes ⚠️
Details
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
dart_flutter_team_lints | None | 2.1.1 | 2.1.1 | 2.1.1 | ✔️ |
firehose | Non-Breaking | 0.3.32 | 0.3.32 | 0.4.0 |
This check can be disabled by tagging the PR with skip-breaking-check
@@ -9,6 +9,8 @@ environment: | |||
dependencies: | |||
args: ^2.3.1 | |||
collection: ^1.17.0 | |||
firehose: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid this path-relative dep if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that blast_repo
not being published means we can relax the principle of reducing the number of imports :) I am also fine with code duplication if that's the lesser evil.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not wrong - avoiding publishing another package is more important. Perhaps add a line of docs here - # Re-using the repo scanning logic from firehose
or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand - does this mean you would rather want to copy the code or add the dep with a comment?
To be used when
dart format
had any changes in a stable SDK release.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.