Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reformat tweak #197

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add reformat tweak #197

wants to merge 3 commits into from

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Nov 16, 2023

To be used when dart format had any changes in a stable SDK release.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

PR Health

Package publish validation ✔️

Details
Package Version Status
package:dart_flutter_team_lints 2.1.1 already published at pub.dev
package:firehose 0.3.32 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Coverage ⚠️

Details
File Coverage
pkgs/firehose/lib/firehose.dart 💔 Not covered
pkgs/firehose/lib/src/health/health.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

Breaking changes ⚠️

Details
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 2.1.1 2.1.1 2.1.1 ✔️
firehose Non-Breaking 0.3.32 0.3.32 0.4.0 ⚠️

This check can be disabled by tagging the PR with skip-breaking-check

pkgs/blast_repo/lib/src/tweaks/reformat_tweak.dart Outdated Show resolved Hide resolved
pkgs/blast_repo/lib/src/tweaks/reformat_tweak.dart Outdated Show resolved Hide resolved
@@ -9,6 +9,8 @@ environment:
dependencies:
args: ^2.3.1
collection: ^1.17.0
firehose:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid this path-relative dep if possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that blast_repo not being published means we can relax the principle of reducing the number of imports :) I am also fine with code duplication if that's the lesser evil.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not wrong - avoiding publishing another package is more important. Perhaps add a line of docs here - # Re-using the repo scanning logic from firehose or similar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand - does this mean you would rather want to copy the code or add the dep with a comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants