Skip to content

Commit

Permalink
Fix analysis issues
Browse files Browse the repository at this point in the history
  • Loading branch information
derekxu16 committed Feb 21, 2024
1 parent af40a78 commit 653e5da
Show file tree
Hide file tree
Showing 4 changed files with 67 additions and 23 deletions.
70 changes: 52 additions & 18 deletions .github/workflows/dart.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 13 additions & 3 deletions pkgs/http_profile/lib/http_profile.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

import 'dart:async' show StreamController, StreamSink;
import 'dart:developer' show addHttpClientProfilingData, Service, Timeline;
import 'dart:developer' show Service, addHttpClientProfilingData;
import 'dart:io' show HttpClient, HttpClientResponseCompressionState;
import 'dart:isolate' show Isolate;

Expand Down Expand Up @@ -288,8 +288,18 @@ final class HttpClientRequestProfile {
/// Usage example:
///
/// ```dart
/// profile.addEvent(HttpProfileRequestEvent(DateTime.now(), "Connection Established");
/// profile.addEvent(HttpProfileRequestEvent(DateTime.now(), "Remote Disconnected");
/// profile.addEvent(
/// HttpProfileRequestEvent(
/// timestamp: DateTime.now(),
/// name: "Connection Established",
/// ),
/// );
/// profile.addEvent(
/// HttpProfileRequestEvent(
/// timestamp: DateTime.now(),
/// name: "Remote Disconnected",
/// ),
/// );
/// ```
void addEvent(HttpProfileRequestEvent event) {
(_data['events'] as List<Map<String, dynamic>>).add(event._toJson());
Expand Down
2 changes: 1 addition & 1 deletion pkgs/http_profile/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ publish_to: none

environment:
# TODO(derekxu16): Change the following constraint to ^3.4.0 before publishing this package.
sdk: ^3.4.0-149.0.dev
sdk: ^3.4.0-154.0.dev

dependencies:
test: ^1.24.9
Expand Down
2 changes: 1 addition & 1 deletion pkgs/http_profile/test/populating_profiles_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

import 'dart:async';
import 'dart:developer' show getHttpClientProfilingData, Service;
import 'dart:developer' show Service, getHttpClientProfilingData;
import 'dart:io';
import 'dart:isolate' show Isolate;

Expand Down

0 comments on commit 653e5da

Please sign in to comment.