fix: missing HTTP method in cronet client #1035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
kientux
force-pushed
the
fix-missing-cronet-http-method
branch
from
c7592f0
to
38eb88f
Compare
kevmoo
reviewed
Nov 21, 2023
| @@ -332,6 +332,7 @@ class CronetClient extends BaseClient { | |||
| builder.setUploadDataProvider( | |||
| jb.UploadDataProviders.create2(body.toJByteBuffer()), _executor); | |||
| } | |||
| builder.setHttpMethod(request.method.toJString()); | |||
There was a problem hiding this comment.
Weird this is not caught in an existing test.
There was a problem hiding this comment.
Because I accidentally deleted the test while also breaking the code :-(
|
I've incorporated your change into #1058 - thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
sendfunction ofCronetClient, HTTP method in request is never set to the builder. With default behavior, Cronet will useGETwhen there's no body andPOSTotherwise, so everyPUTrequest will becomePOST.This PR just set the missing HTTP method to the builder.