Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reachability barrier #50080

Closed
polina-c opened this issue Sep 28, 2022 · 3 comments
Closed

Implement reachability barrier #50080

polina-c opened this issue Sep 28, 2022 · 3 comments
Assignees
@a-siva
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on

Comments

@polina-c
Copy link
Contributor

polina-c commented Sep 28, 2022 •
edited
Loading

This is a follow up for GCClock discussion at go/flutter-devtools-sync.

Implement API int gcCount in dart:developer, and make it available in profile and debug modes.

Suggested documentation:

The value increases when full cycle of garbage collection happened.

It is not guaranteed for each full cycle of garbage collection to result in the counter increase.
However, it is guaranteed that, if an object did not have retaining path to the app root when the value
switched to n, it will be garbage collected by the time when the value switched to n + 1.
@polina-c polina-c added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Sep 28, 2022
@polina-c polina-c mentioned this issue Sep 28, 2022
Open
@polina-c
Copy link
Contributor Author

polina-c commented Nov 1, 2022

https://dart-review.googlesource.com/c/sdk/+/266424

@a-siva a-siva added P2 A bug or feature request we're likely to work on vm-triaged labels Nov 4, 2022
@a-siva a-siva self-assigned this Nov 4, 2022
@a-siva
Copy link
Contributor

a-siva commented Nov 4, 2022

CL in progress here https://dart-review.googlesource.com/c/sdk/+/266424

@a-siva a-siva changed the title Implement gcCount. Implement reachability barrier Nov 9, 2022
@a-siva
Copy link
Contributor

a-siva commented Nov 9, 2022

Submitted https://dart-review.git.corp.google.com/c/sdk/+/266424

@a-siva a-siva closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-siva @polina-c