Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leak-tracker: Detect memory leaks by identifying not disposed or not GCed objects. #3951

Open
polina-c opened this issue Apr 1, 2022 · 5 comments
Assignees
Labels
P1 high priority issues at the top of the work list, actively being worked on. screen: memory Issues with the Memory screen.
Milestone

Comments

@polina-c
Copy link
Contributor

polina-c commented Apr 1, 2022

Motivation: go/flutter-devtools-survey-2022

@polina-c polina-c added the screen: memory Issues with the Memory screen. label Apr 1, 2022
@polina-c polina-c added this to the M39 milestone Apr 1, 2022
@polina-c polina-c self-assigned this Apr 1, 2022
@polina-c
Copy link
Contributor Author

polina-c commented Apr 1, 2022

@polina-c polina-c assigned terrylucas and unassigned terrylucas Apr 6, 2022
@flutter flutter deleted a comment from terrylucas Apr 6, 2022
@polina-c polina-c changed the title Memory leaks: detect disposed, not GC-ed links Detect memory leaks by identifying not disposed or not GCed objects. Apr 7, 2022
@kenzieschmoll kenzieschmoll modified the milestones: M39, M41 May 5, 2022
@polina-c polina-c added the P3 label May 20, 2022
@polina-c
Copy link
Contributor Author

Options for Flutter specific leak tracker:

  1. package:leak_tracker_flutter published in tools.dart.dev, and banking on 'flutter' in the name being clarifying enough
  2. keeping leak_tracker_flutter in the same mono-repo, but publishing it out of the flutter.dev publisher
  3. putting the code in the flutter/packages mono-repo and using the flutter.dev publisher

@devoncarew leans towards the 2nd and 3rd options

@stuartmorgan
Copy link

2. keeping leak_tracker_flutter in the same mono-repo, but publishing it out of the flutter.dev publisher

It appears we did this; is there discussion/context somewhere on why that option was chosen? AFAIK this is the only flutter.dev-published package that is not in flutter/packages, which makes this pretty confusing.

@polina-c
Copy link
Contributor Author

  1. keeping leak_tracker_flutter in the same mono-repo, but publishing it out of the flutter.dev publisher

It appears we did this; is there discussion/context somewhere on why that option was chosen? AFAIK this is the only flutter.dev-published package that is not in flutter/packages, which makes this pretty confusing.

Here is the issue with discussion: dart-lang/leak_tracker#52 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 high priority issues at the top of the work list, actively being worked on. screen: memory Issues with the Memory screen.
Projects
None yet
Development

No branches or pull requests

4 participants