Collect retaining path. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/src/leak_tracking/retaining_path/_json_to_service_cache.dart
Outdated
Show resolved
Hide resolved
lib/src/leak_tracking/retaining_path/_vm_service_private_extensions.dart
Outdated
Show resolved
Hide resolved
|
CC @bkonyi |
Cleaned up what I do not use and created bug for tech debt: flutter/devtools#5837 |
| return null; | ||
| } | ||
|
|
||
| class _ItemInIsolate { |
There was a problem hiding this comment.
nit would it make more sense to name this _ObjectInIsolate? This would match the method name _objectInIsolate
There was a problem hiding this comment.
Sometimes it is a class. Added comment.
| @@ -125,11 +132,17 @@ Future<List<_ItemInIsolate>> _findClasses(String runtimeClassName) async { | |||
| for (final isolateId in _isolateIds) { | |||
| var classes = await _service.getClassList(isolateId); | |||
|
|
|||
| const watingTime = Duration(seconds: 2); | |||
| final stopwatch = Stopwatch()..start(); | |||
There was a problem hiding this comment.
does this stop watch need to be stopped at some point?
There was a problem hiding this comment.
No, it is not doing any background work.
kenzieschmoll
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.