Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: move features of VmServiceWrapper from DevTools to VmService. #5837

Closed
polina-c opened this issue May 22, 2023 · 2 comments · Fixed by #6508
Closed

Tech debt: move features of VmServiceWrapper from DevTools to VmService. #5837

polina-c opened this issue May 22, 2023 · 2 comments · Fixed by #6508
Assignees
@kenzieschmoll
Labels
fix it friday P2 important to work on, but not at the top of the work list. tech debt

Comments

@polina-c
Copy link
Contributor

We need to update VmServiceWrapper every time VmService is updated.

We will save this effort by moving the features to VmService.
@polina-c
Copy link
Contributor Author

@bkonyi
@kenzieschmoll

@polina-c polina-c mentioned this issue May 22, 2023
Merged
@kenzieschmoll
Copy link
Member

We could also benefit from moving the logic to connect to a vm service over to package:vm_service. This can be reused by any vm service client that needs to establish connection (devtools, leak tracker, devtools plugins, etc.)

@CoderDake CoderDake added the P2 important to work on, but not at the top of the work list. label Aug 14, 2023
@kenzieschmoll kenzieschmoll mentioned this issue Oct 12, 2023
Merged
@kenzieschmoll kenzieschmoll self-assigned this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenzieschmoll kenzieschmoll

Labels
fix it friday P2 important to work on, but not at the top of the work list. tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump to vm_service 13.0.0 and reduce VmServiceWrapper. kenzieschmoll/devtools
3 participants
@CoderDake @polina-c @kenzieschmoll