Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Add missing promotion of Finalizer external size. #51798

Closed
rmacnak-google opened this issue Mar 20, 2023 · 3 comments
Closed

[CP] Add missing promotion of Finalizer external size. #51798

rmacnak-google opened this issue Mar 20, 2023 · 3 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@rmacnak-google
Copy link
Contributor

Commit(s) to merge

f4b34ad

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/289941

Issue Description

False OutOfMemory exceptions due to a VM accounting bug.

What is the fix

Properly promote external size.

Why cherry-pick

Users have encountered this issue on stable #50537 (comment) and there is no way from the Dart program to work around this.

Risk

medium

Issue link(s)

#50537

Extra Info

No response
@rmacnak-google rmacnak-google added the cherry-pick-review Issue that need cherry pick triage to approve label Mar 20, 2023
@itsjustkevin
Copy link
Contributor

@alexmarkov could you take a look at this cherry-pick for approval?

@alexmarkov
Copy link
Contributor

lgtm

@itsjustkevin itsjustkevin added cherry-pick-approved Label for approved cherrypick request merge-to-stable labels Mar 21, 2023
@mit-mit mit-mit added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Mar 22, 2023
copybara-service bot pushed a commit that referenced this issue Mar 28, 2023
@itsjustkevin
[Release] Version 2.19.6
5b89364 
- Fixes an `Out of Memory` exception due to a VM bug.
#51798



Change-Id: I81f259c2b7a75d90a8208990f3e53ff46d151c90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291205
Reviewed-by: Alexander Thomas <athom@google.com>
@xunreal75
Copy link

Does not fix out of Memory issue - Context and _Closure are growing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@vsmenon @xunreal75 @rmacnak-google @itsjustkevin @mit-mit @athomas @alexmarkov