Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] [Stable] Please cherry pick 82520abfb1dd82b36e4a50371e71572b2bd95b73 and 84b38aee393d9afc5f2cc83b8a816230478d0646 #54698

Closed
a-siva opened this issue Jan 23, 2024 · 2 comments
Closed

[CP] [Stable] Please cherry pick 82520abfb1dd82b36e4a50371e71572b2bd95b73 and 84b38aee393d9afc5f2cc83b8a816230478d0646 #54698

a-siva opened this issue Jan 23, 2024 · 2 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
cherry-pick-review Issue that need cherry pick triage to approve

Comments

@a-siva
Copy link
Contributor

a-siva commented Jan 23, 2024

Commit(s) to merge

82520ab and 84b38ae

Target

stable and beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/347760

Issue Description

The change fixes the following

  • an issue that causes Flutter apps to freeze when breakpoints are added to multiple isolates at the same time
  • an issue that causes Flutter apps to crash during hot reload

What is the fix

  • Use safepoint-safe RwLock for breakpoint locations locks
  • Ensure setting breakpoints is lock-safe

Why cherry-pick

Flutter app developers have encountered these scenarios effecting developer productivity.

Risk

low

Issue link(s)

#54650

Extra Info

No response
@a-siva a-siva added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 23, 2024
@mit-mit
Copy link
Member

mit-mit commented Jan 23, 2024

SGTM

@a-siva
Copy link
Contributor Author

a-siva commented Jan 23, 2024

Closing this as a duplicate of #54699. Will carry over @mits comment to the other issue.

@a-siva a-siva closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vsmenon @whesse @a-siva @itsjustkevin @mit-mit @athomas