[CP] [Stable][Beta] Please cherry pick 82520abfb1dd82b36e4a50371e71572b2bd95b73 and 84b38aee393d9afc5f2cc83b8a816230478d0646 #54699
Comments
a-siva
added
the
cherry-pick-review
|
//cc @aam |
|
@mit commented with a SGTM on the other issue. |
a-siva
added
the
area-vm
itsjustkevin
changed the title
itsjustkevin
added
cherry-pick-approved
…ions locks and Ensure setting breakpoints is lock-safe. TEST=DartAPI_BreakpointLockRace and DeoptimizeFramesWhenSettingBreakpoint Fixes #54650 flutter/flutter#140878 Acquire reload opreation scope when deoptimizing the world to ensure locks can be acquired for compilation. Set up scope for operations that can be run while the world is deoptimized and stopped to avoid races. Ensure code stays unoptizimed when single stepping, prevent other isolates to reoptimize. Bug: #54650 and flutter/flutter#140878 Change-Id: I9a88096f15a34b645281e5b2b3805a73dd93672e Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/347420 and https://dart-review.googlesource.com/c/sdk/+/345743 Cherry-pick-request: #54699 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347650 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
|
@itsjustkevin thanks for taking care of the stable merge, should I go ahead and submit the beta branch CL ? |
|
Yes @a-siva please push the beta CL also. |
…ns locks and Ensure setting breakpoints is lock-safe. Acquire reload opreation scope when deoptimizing the world to ensure locks can be acquired for compilation. Set up scope for operations that can be run while the world is deoptimized and stopped to avoid races. Ensure code stays unoptizimed when single stepping, prevent other isolates to reoptimize it. Fixes: #54650 flutter/flutter#140878 TEST=DartAPI_BreakpointLockRace and DeoptimizeFramesWhenSettingBreakpoint Bug: #54650 and flutter/flutter#140878 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/347420 and https://dart-review.googlesource.com/c/sdk/+/345743 Cherry-pick-request: #54699 Change-Id: Ia4bc883121dac978fbb76027906a810000ef1138 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347760 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Siva Annamalai <asiva@google.com>
|
Just checking how long this fix will take to be available? I've been very eagerly tracking and waiting for a resolution to this issue while I cant debug my projects. Appreciate your efforts on this. |
I believe a hotfix release of Flutter is slated for today. |
Done, closing issue. |
|
Thank you! I just verified this on the new stable Flutter and all looks good :-) |
Commit(s) to merge
82520ab and 84b38ae
Target
stable and beta
Prepared changelist for beta/stable
stable - https://dart-review.googlesource.com/c/sdk/+/347650
beta - https://dart-review.googlesource.com/c/sdk/+/347760
Issue Description
The change fixes the following
What is the fix
Why cherry-pick
Flutter app developers have encountered these scenarios effecting developer productivity.
Risk
low
Issue link(s)
#54650
flutter/flutter#140878
Extra Info
No response
The text was updated successfully, but these errors were encountered: