[CP] [dart2wasm] Fix partial instantiation constants #56440
Assignees
Labels
area-dart2wasm
Issues for the dart2wasm compiler.
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-review
Issue that need cherry pick triage to approve
type-bug
Incorrect behavior (everything from a crash to more subtle misbehavior)
Comments
mkustermann
added
the
cherry-pick-review
|
/cc @kevmoo for visibility (we want this to be also included in the dot release) |
|
Summary: The Dart2Wasm compiler crashes when using partially instantiated generic methods with named parameters. This fix addresses the issue by correcting the code that handles these constants. |
dart-github-bot
added
area-dart2wasm
7 tasks
|
@athomas Could we get this approved so it gets included in the upcoming hotfix release? |
|
@mkustermann based on previous discussions, I am going to mark this cherry-pick approved. |
itsjustkevin
added
the
cherry-pick-approved
copybara-service bot
pushed a commit
that referenced
this issue
Aug 13, 2024
Partial instantiation constants are closures. Those closures have vtables with all entries needed for the closure representation corresponding to the instantiated closure. The entries of those vtables have to either call the corresponding method of the generic closure, or are unreachable dummy entries. Dummy entries can be required due to clustering callees/callers together where a particular target doesn't support the name combination. The case that was incorrect is if the particular name combination did not get clustered with anything for the generic closure representation. Issue #56372 TEST=web/wasm/regress_56372_test Bug: #56372 Change-Id: I7a219237519c39d982b89ce272f33fb4d90cd173 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/380100 Cherry-pick-request: #56440 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380120 Reviewed-by: Ömer Ağacan <omersa@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Thanks a lot, @itsjustkevin. Merged the PR (No more cherry-picks for dart2wasm in the SDK (still one dependent in flutter/flutter - flutter/flutter#153310) ) |
lrhn
removed
the
triage-automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
f7fc4d0
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/380120
Issue Description
Using partial instantiation constants of generic methods with named parameters can in certain situations lead to compiler crashes.
What is the fix
Fix the code that handles partial instantiation constants in dart2wasm.
Why cherry-pick
Users have hit this problem.
Risk
If all tests pass: low.
Issue link(s)
#56372
Extra Info
No response
The text was updated successfully, but these errors were encountered: