Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to fix strong-mode errors #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

natebosch
Copy link

  • Add analysis_options so the analyzer runs in strong mode
  • Add covariant BigInteger to many method arguments to fix errors
    where a function taking a specific type was overriding a method taking
    dynamic.
  • Add specific type arguments to methods which use fields from the
    implementations that don't exist on BigInteger
  • Restrict SDK to >1.22 to pick up covariant keyword

This is the minimal change to make the package strong mode clean, and
hopefully compatible with DDC.

- Add analysis_options so the analyzer runs in strong mode
- Add `covariant BigInteger` to many method arguments to fix errors
  where a function taking a specific type was overriding a method taking
  `dynamic`.
- Add specific type arguments to methods which use fields from the
  implementations that don't exist on `BigInteger`
- Restrict SDK to >1.22 to pick up `covariant` keyword

This is the minimal change to make the package strong mode clean, and
hopefully compatible with DDC.
@natebosch
Copy link
Author

This should fix #39

@davidmorgan
Copy link

@kaendfinger any chance you could take a look at this please -- we are eager for the fix :)

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants