Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace M_PI with dart::math::constantsd::pi() #1367

Merged
merged 8 commits into from
Jul 8, 2019
Merged

Replace M_PI with dart::math::constantsd::pi() #1367

merged 8 commits into from
Jul 8, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 7, 2019

This PR depends on #1366


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Jul 7, 2019
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@420241d). Click here to learn what that means.
The diff coverage is 45.28%.

@@            Coverage Diff            @@
##             master    #1367   +/-   ##
=========================================
  Coverage          ?   56.88%           
=========================================
  Files             ?      366           
  Lines             ?    27389           
  Branches          ?        0           
=========================================
  Hits              ?    15581           
  Misses            ?    11808           
  Partials          ?        0
Impacted Files Coverage Δ
dart/common/sub_ptr.hpp 100% <ø> (ø)
dart/dynamics/detail/PlanarJointAspect.hpp 100% <ø> (ø)
...art/dynamics/detail/TranslationalJoint2DAspect.hpp 50% <ø> (ø)
dart/collision/bullet/BulletCollisionDetector.cpp 70.15% <0%> (ø)
dart/dynamics/detail/GenericJointAspect.hpp 50% <0%> (ø)
dart/dynamics/detail/PlanarJointAspect.cpp 86.88% <100%> (ø)
dart/common/detail/sub_ptr.hpp 95.65% <100%> (ø)
dart/utils/VskParser.cpp 72.13% <100%> (ø)
dart/dynamics/detail/BodyNodePtr.hpp 93.67% <100%> (ø)
...art/dynamics/detail/TranslationalJoint2DAspect.cpp 32.05% <50%> (ø)

@jslee02 jslee02 merged commit 54cfb73 into master Jul 8, 2019
@jslee02 jslee02 deleted the m_pi branch July 8, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant