Fix refresh of LineSegmentShapeNode #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
=======================================
Coverage 56.97% 56.97%
=======================================
Files 366 366
Lines 27460 27460
=======================================
Hits 15646 15646
Misses 11814 11814 |
mxgrey
requested changes
Jul 31, 2019
| ::osg::ref_ptr<::osg::DrawElementsUInt> elements | ||
| = new ::osg::DrawElementsUInt(::osg::PrimitiveSet::LINES); | ||
| elements->reserve(2 * connections.size()); | ||
| mElements->resize(2 * connections.size()); |
There was a problem hiding this comment.
I don't think we want to use resize(~) alongside push_back(~), because that means we're going to make mElements the size 2 * connections.size() and then later push back an additional 2 * connections.size() number of new elements.
I would recommend using reserve(2 * connections.size() and then clear().
There was a problem hiding this comment.
Alternatively resize(~) and then [2*i] = and [2*i+1] = would also work, but that feels more risky to me.
There was a problem hiding this comment.
Thanks for catching this out. Let me fix this as suggested.
mxgrey
approved these changes
Jul 31, 2019
|
It was an easy fix! Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LineSegmentShapeNodekeeps adding new line segments instead of refreshing with new line. See the details in #1380 and this post.Resolves #1380.
Before creating a pull request
clang-formatBefore merging a pull request
CHANGELOG.md