Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError from dartpy.dynamics.Node.getBodyNodePtr() #1463

Merged
merged 3 commits into from
May 10, 2020

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 10, 2020

dartpy.dynamics.Node.getBodyNodePtr() causes TypeError as

>>> b.getBodyNodePtr()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: Unable to convert function return value to a Python type! The signature was
	(self: dartpy.dynamics.Node) -> dart::dynamics::TemplateBodyNodePtr<dart::dynamics::BodyNode>

This was because dart::dynamics::TemplateBodyNodePtr<dart::dynamics::BodyNode> is declared after the Node binding. This PR fixes it by declaring the holder type at the top of dynamics submodule.

This PR needs to be merged before #1457.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone May 10, 2020
@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #1463 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1463      +/-   ##
==========================================
+ Coverage   58.23%   58.24%   +0.01%     
==========================================
  Files         412      412              
  Lines       29928    29928              
==========================================
+ Hits        17429    17432       +3     
+ Misses      12499    12496       -3     
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.33% <0.00%> (+0.16%) ⬆️

@jslee02 jslee02 merged commit 19c33a6 into master May 10, 2020
@jslee02 jslee02 deleted the dartpy_body_node_ptr branch May 10, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant