Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce to use OSG 3.7.0 or greater on macOS Catalina #1479

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 26, 2020

OpenSceneGraph 3.6.5 or less are not compatible with macOS 10.15 (Catalina) or greater (openscenegraph/OpenSceneGraph#926, #1439). This PR increases the required minimum OSG version for macOS Catalina to 3.7.0 that includes the fix.

Resolves #1439


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 changed the title Enforce to use OSG 3.7.0 or greater for macOS Catalina Enforce to use OSG 3.7.0 or greater on macOS Catalina Jul 26, 2020
@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #1479 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1479      +/-   ##
==========================================
+ Coverage   58.18%   58.20%   +0.02%     
==========================================
  Files         412      412              
  Lines       29913    29913              
==========================================
+ Hits        17406    17412       +6     
+ Misses      12507    12501       -6     
Impacted Files Coverage Δ
dart/dynamics/EulerJoint.cpp 73.00% <0.00%> (+3.68%) ⬆️

@jslee02 jslee02 merged commit 3f61c50 into master Jul 28, 2020
@jslee02 jslee02 deleted the catalina_osg branch July 28, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal instruction: 4 when running atlas_simbicon example on mac
1 participant