Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed intrinsic and extrinsic camera parameters in OpenGL projection matrix #1485

Merged
merged 2 commits into from
Aug 16, 2020

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 16, 2020

This PR fixes the incorrect projection matrix computation in OpenGL due to the misplaced gluLookAt() calls.

Fixes #1484.


Before creating a pull request

  • (N/A) Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • (N/A) Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 16, 2020
@jslee02 jslee02 marked this pull request as ready for review August 16, 2020 01:12
@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #1485 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1485   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files         414      414           
  Lines       30004    30004           
=======================================
  Hits        17419    17419           
  Misses      12585    12585           

@jslee02 jslee02 merged commit a373957 into master Aug 16, 2020
@jslee02 jslee02 deleted the bugfix/projection_matrix_glulookat branch August 16, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed intrinsic and extrinsic camera parameter in OpenGL projection matrix
1 participant