Adds functional (typescript) tests for Eth RPC (#74)

* Adds functional (typescript) tests for Eth RPC

* Adds not supported for compilers rpc methods

* Adds tests for compilers, estimateGas and contract

* Fix formatting

* Adds more tests

* Use editorconfig instead of prettier for TS

* Adds test for gas recomputation

* Adds log documentation for ts tests

* More tests + formatting

* draft for CI functional test integration

* Better support for nodejs in rust CI

* testing CI integration for NodeJs

.github/workflows/rust.yml

@@ -27,3 +27,11 @@ jobs:
       run: cargo build --verbose --all
     - name: Run tests
       run: cargo test --verbose --all
+    - name: Use Node.js 10
+      uses: actions/setup-node@v1
+      with:
+        node-version: 10
+    - name: Install functional tests typescript
+      run: cd ts-tests && npm install
+    - name: Run functional tests
+      run: cd ts-tests && npm run test

.gitignore

@@ -1,4 +1,5 @@
 **/target/
+**/node_modules/
 **/*.rs.bk
 *.swp
 .wasm-binaries

Cargo.toml

@@ -7,8 +7,10 @@ members = [
 	"template/node",
 	"template/runtime",
 	"template/test-utils/client",
+	"ts-tests/frontier-test-node/node",
+	"ts-tests/frontier-test-node/runtime",
 ]
 exclude = ["vendor"]
 
 [patch.crates-io]
-ethereum = { path = "vendor/ethereum" }
+ethereum = { path = "vendor/ethereum" }

rpc/src/lib.rs

@@ -44,6 +44,13 @@ fn internal_err(message: &str) -> Error {
 		data: None
 	}
 }
+fn not_supported_err(message: &str) -> Error {
+	Error {
+		code: ErrorCode::InvalidRequest,
+		message: message.to_string(),
+		data: None
+	}
+}
 
 pub struct EthApi<B: BlockT, C, SC, P, CT, BE> {
 	pool: Arc<P>,
@@ -649,19 +656,19 @@ impl<B, C, SC, P, CT, BE> EthApiT for EthApi<B, C, SC, P, CT, BE> where
 	}
 
 	fn compilers(&self) -> Result<Vec<String>> {
-		unimplemented!("compilers");
+		Err(not_supported_err("Method eth_getCompilers not supported."))
 	}
 
 	fn compile_lll(&self, _: String) -> Result<Bytes> {
-		unimplemented!("compile_lll");
+		Err(not_supported_err("Method eth_compileLLL not supported."))
 	}
 
 	fn compile_solidity(&self, _: String) -> Result<Bytes> {
-		unimplemented!("compile_solidity");
+		Err(not_supported_err("Method eth_compileSolidity not supported."))
 	}
 
 	fn compile_serpent(&self, _: String) -> Result<Bytes> {
-		unimplemented!("compile_serpent");
+		Err(not_supported_err("Method eth_compileSerpent not supported."))
 	}
 
 	fn logs(&self, _: Filter) -> BoxFuture<Vec<Log>> {

template/Dockerfile

@@ -33,4 +33,4 @@ ENV PROFILE ${PROFILE}
 # The execution will re-compile the project to run it
 # This allows to modify the code and not have to re-compile the
 # dependencies.
-CMD cargo run "--$PROFILE" -- --dev
+CMD cargo run --bin frontier-template-node "--$PROFILE" -- --dev

ts-tests/.gitignore

@@ -0,0 +1,2 @@
+node_modules/
+frontier-test-tmp

ts-tests/README.md

@@ -0,0 +1,30 @@
+# Functional testing for Substrate Frontier Node RPC
+
+This folder contains a set of functional tests desgined to perform functional testing on the Frontier Eth RPC.
+
+It is written in typescript, using Mocha/Chai as Test framework.
+
+## Test flow
+
+Tests are separated depending of their genesis requirements.
+Each group will start a [frontier test node](frontier-test-node) with a given [spec](substrate-specs) before executing the tests.
+
+## Installation
+
+```
+npm install
+```
+
+## Run the tests
+
+```
+npm run test
+```
+
+You can also add the Frontier Node logs to the output using the `FRONTIER_LOG` env variable. Ex:
+
+```
+FRONTIER_LOG="warn,rpc=trace" npm run test
+```
+
+(The frontier node be listening for RPC on port 19933, mostly to avoid conflict with already running substrate node)

ts-tests/frontier-test-node/README.md

@@ -0,0 +1,3 @@
+# Substrate Frontier Node for functional testing
+
+**Warning**: This node is only used to run tests.