Support PHP 8.4 #110
Merged
Support PHP 8.4 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foo(string $bar = null) is deprecated, use foo(?string $bar = null) instead.
PHP 5.6 and 7.0 are so old that the don't support the '?' nullable parameter. Do support PH> 8.4, these versions have to be dropped now.
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Aug 12, 2024
Activate PHP 8.4 functional tests in pre-merge and a nightly combination. Similar to unit tests with #104578, we patch another library: enshrined/svg-sanitize. A patch is pending [1], but not yet merged nor released. Codewise its trivial. Some tests need a minor adaption since XML files are created slightly differently with PHP 8.4, the change aligns the fixtures to deal with this. [1] darylldoyle/svg-sanitizer#110 Resolves: #104604 Related: #104578 Releases: main Change-Id: I5d99275aa14d56c35894b270a7f111a50fd56ab7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85592 Reviewed-by: Garvin Hicking <gh@faktor-e.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Garvin Hicking <gh@faktor-e.de>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this pull request
Aug 12, 2024
Activate PHP 8.4 functional tests in pre-merge and a nightly combination. Similar to unit tests with #104578, we patch another library: enshrined/svg-sanitize. A patch is pending [1], but not yet merged nor released. Codewise its trivial. Some tests need a minor adaption since XML files are created slightly differently with PHP 8.4, the change aligns the fixtures to deal with this. [1] darylldoyle/svg-sanitizer#110 Resolves: #104604 Related: #104578 Releases: main Change-Id: I5d99275aa14d56c35894b270a7f111a50fd56ab7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85592 Reviewed-by: Garvin Hicking <gh@faktor-e.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Garvin Hicking <gh@faktor-e.de>
|
Friendly ping. |
darylldoyle
approved these changes
Sep 5, 2024
|
Thank you for this @lolli42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #109