Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform)!: contests on testnet/devnet/local should take less time #2115

Merged
merged 8 commits into from
Sep 15, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Sep 12, 2024

Issue being fixed or feature implemented

Contests on Testnet took 2 weeks to resolve. This was bad for testing

What was done?

Contests on Testnet/Devnet/Local now will take 90 mins to resolve.

How Has This Been Tested?

Breaking Changes

This is a breaking change for testnet. It can only be activated with V2 of protocol.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov
Copy link
Member

shumkov commented Sep 12, 2024

The network field in Drive config will be filled from the NETWORK env. We already pass it in dashmate

@QuantumExplorer
Copy link
Member Author

Ivan had reviewed, merging in.

@QuantumExplorer QuantumExplorer merged commit 59d2e45 into v1.3-dev Sep 15, 2024
75 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/ContestsOnTestnetShouldTakeLessTime branch September 15, 2024 20:35
@shumkov shumkov changed the title feat(platform)!: contests on testnet should take less time feat(platform)!: contests on testnet/devnet/local should take less time Sep 16, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve done post review. LGTM

@thephez thephez added this to the v1.3.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants