Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate)!: confirm a node reset #2160

Open
wants to merge 1 commit into
base: v1.4-dev
Choose a base branch
from

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Sep 22, 2024

Issue being fixed or feature implemented

The reset command removes a node data and potentially configuration (if the hard flag is provided). A user must be warned before the command is actually executing.

What was done?

  • Added prompt to the reset command if the force flag is not provided.

How Has This Been Tested?

Running the reset command locally

Breaking Changes

This change will break any non interactive execution of reset command so now the force flag must be provided to skip the reset confirmation.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title feat(dashmate)!: confirm reset feat(dashmate)!: confirm a node reset Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant