Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xfail some parquet tests due to item -> element change in pyarrow 13 #352

Merged

Conversation

douglasdavis
Copy link
Collaborator

@douglasdavis douglasdavis commented Aug 25, 2023

following our solving of #346 we can xfail failing tests based on version combinations

@codecov-commenter
Copy link

Codecov Report

Merging #352 (bf4a663) into main (e30ad13) will increase coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head bf4a663 differs from pull request most recent head ee426a6. Consider uploading reports for the commit ee426a6 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   94.80%   94.81%   +0.01%     
==========================================
  Files          20       20              
  Lines        2481     2487       +6     
==========================================
+ Hits         2352     2358       +6     
  Misses        129      129              
Files Changed Coverage Δ
src/dask_awkward/lib/io/parquet.py 92.07% <100.00%> (ø)
src/dask_awkward/lib/testutils.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglasdavis douglasdavis merged commit abe7f45 into dask-contrib:main Aug 25, 2023
19 checks passed
@douglasdavis douglasdavis deleted the xfail-parquet-based-on-versions branch August 25, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants