Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mismatch between declared CRDs and struct for DaskAutoscalers #894

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

JordanGunn
Copy link

Description

This pull request addresses a mismatch identified between the declared Custom Resource Definitions (CRDs) for Kubernetes resources and the DaskAutoscalerSpec struct in the Go client.

Problem

The issue lies with the minimum and maximum attributes in the DaskAutoscalerSpec struct, which were initially declared as string types but should be int, as declared in the CRDs. This disparity causes issues between the Go client and the registered Kubernetes scheme.

Solution

I have resolved this bug by altering the DaskAutoscalerSpec struct to use int for the max and min attributes, ensuring consistency with the CRD. Subsequently, I ran the code autogeneration script to validate that there are no adverse side-effects from these changes.

Thank you for your consideration.

Copy link
Collaborator

@bstadlbauer bstadlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an oversight on my end - thanks for diving in and fixing it! 🙇

@bstadlbauer
Copy link
Collaborator

@jacobtomlinson I've taken this as an opportunity to go over the go pre-commit tooling to make sure it still works and it seems like it does 👍

@bstadlbauer bstadlbauer merged commit 6d3d9b2 into dask:main Jun 12, 2024
11 checks passed
@JordanGunn JordanGunn deleted the autoscalerspec-minmax-int branch June 13, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants