Skip to content

Commit

Permalink
avoid pristine_loop/loop.start in loop_in_thread
Browse files Browse the repository at this point in the history
  • Loading branch information
graingert committed May 23, 2022
1 parent 2a26311 commit cabab46
Showing 1 changed file with 23 additions and 10 deletions.
33 changes: 23 additions & 10 deletions distributed/utils_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,16 +170,29 @@ def start():

@pytest.fixture
def loop_in_thread(cleanup):
with pristine_loop() as loop:
thread = threading.Thread(target=loop.start, name="test IOLoop")
thread.daemon = True
thread.start()
loop_started = threading.Event()
loop.add_callback(loop_started.set)
loop_started.wait()
yield loop
loop.add_callback(loop.stop)
thread.join(timeout=5)
loop_started = concurrent.futures.Future()
with concurrent.futures.ThreadPoolExecutor(
1, thread_name_prefix="test IOLoop"
) as tpe:

async def run():
io_loop = IOLoop.current()
stop_event = asyncio.Event()
loop_started.set_result((io_loop, stop_event))
await stop_event.wait()

ran = tpe.submit(_run_and_close_tornado, run)
for f in concurrent.futures.as_completed((loop_started, ran)):
if f is loop_started:
io_loop, stop_event = loop_started.result()
try:
yield io_loop
finally:
io_loop.add_callback(stop_event.set)

elif f is ran:
ran.result()
return


@pytest.fixture
Expand Down

0 comments on commit cabab46

Please sign in to comment.