-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that adaptive only stops once #8807
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ± 0 29 suites ±0 11h 52m 59s ⏱️ - 2m 1s For more details on these failures, see this check. Results for commit 6c01e8f. ± Comparison against base commit c44ad22. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW it looks like the windows failures are related to the changes here
Traceback (most recent call last):
File "C:\Users\runneradmin\miniconda3\envs\dask-distributed\Lib\site-packages\tornado\ioloop.py", line 750, in _run_callback
ret = callback()
^^^^^^^^^^
File "D:\a\distributed\distributed\distributed\deploy\adaptive_core.py", line 151, in _start
if self._state != "starting":
^^^^^^^^^^^
AttributeError: 'Adaptive' object has no attribute '_state'
Good catch, thanks @jrbourbeau! This should now be fixed. I'm a little stunned by the fact that this didn't show up in the test summary. |
On
main
, Adaptive could get stopped multiple times, issuing anAdaptive stop
log message each time. This could get confusing if adaptive is replaced because thestop
logs of the old Adaptive might appear after thestart
log of the new one.Example
This PR avoids that.
pre-commit run --all-files