Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that adaptive only stops once #8807

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented Jul 31, 2024

On main, Adaptive could get stopped multiple times, issuing an Adaptive stop log message each time. This could get confusing if adaptive is replaced because the stop logs of the old Adaptive might appear after the start log of the new one.

Example

2024-07-31 09:13:47,960 - distributed.deploy.adaptive_core - INFO - Adaptive stop
2024-07-31 09:13:47,960 - distributed.deploy.adaptive - INFO - Adaptive scaling started: minimum=5 maximum=990
2024-07-31 09:13:48,460 - distributed.deploy.adaptive_core - INFO - Adaptive stop

This PR avoids that.

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait changed the title Adaptive only stops once Ensure that adaptive only stops once Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ± 0      29 suites  ±0   11h 52m 59s ⏱️ - 2m 1s
 4 093 tests + 1   3 981 ✅ +10    111 💤 ±0  1 ❌  - 9 
55 367 runs  +14  52 936 ✅ +22  2 430 💤 +1  1 ❌  - 9 

For more details on these failures, see this check.

Results for commit 6c01e8f. ± Comparison against base commit c44ad22.

♻️ This comment has been updated with latest results.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW it looks like the windows failures are related to the changes here

Traceback (most recent call last):

  File "C:\Users\runneradmin\miniconda3\envs\dask-distributed\Lib\site-packages\tornado\ioloop.py", line 750, in _run_callback

    ret = callback()

          ^^^^^^^^^^

  File "D:\a\distributed\distributed\distributed\deploy\adaptive_core.py", line 151, in _start

    if self._state != "starting":

       ^^^^^^^^^^^

AttributeError: 'Adaptive' object has no attribute '_state'

@hendrikmakait
Copy link
Member Author

Good catch, thanks @jrbourbeau! This should now be fixed. I'm a little stunned by the fact that this didn't show up in the test summary.

@hendrikmakait hendrikmakait merged commit 564f28b into dask:main Jul 31, 2024
32 of 34 checks passed
@hendrikmakait hendrikmakait deleted the adaptive-stops-once branch July 31, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants