Doc validation framework #1167
Open
Doc validation framework #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souravbaner-da
added
the
documentation
souravbaner-da
requested review from
gueniai,
neilbest-db,
sriram251-code and
aman-db
sriram251-code
requested changes
Mar 18, 2024
...atch_docs/content/DeployOverwatch/PipelineValidationFramework/DeepDiveValidationFramework.md
Show resolved
Hide resolved
sriram251-code
requested changes
Mar 18, 2024
...atch_docs/content/DeployOverwatch/PipelineValidationFramework/DeepDiveValidationFramework.md
Show resolved
Hide resolved
|
sriram251-code
approved these changes
Mar 26, 2024
|
@souravbaner-da Add info to the docs on how to schedule the last task to do Validation |
neilbest-db
reviewed
Jul 29, 2024
There was a problem hiding this comment.
@souravbaner-da, please use code markdown for table_names, Validation_Identifiers, and 'literal values'.
neilbest-db
requested changes
Jul 29, 2024
- Use markdown for Spark `table_name`s, Scala `identifier`s, and
`'literal values'` more consistently
- Simplify and reuse column descriptions in tables
- Simplify the text by replacing passive ("is done"),
conditional ("would be done"), and second-person ("we do") verbs
with imperatives or nouns.
- Simplify the text by removing unnecessary adverbs ("basically",
|
@neilbest-db I have reformated the DeepDiveValidationFramework.md to make it more generalized |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation added for Validation Framework.
Close #1111