correctly integrate cancelAllRuns audit events with job runs #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_bronze to mapType
commit a6a13fe Author: Neil Best <neil.best@databricks.com> Date: Thu May 23 16:39:58 2024 -0500 improve TransformationDescriberTest commit 1f145aa Author: Neil Best <neil.best@databricks.com> Date: Thu May 23 15:25:29 2024 -0500 Add descriptive job group IDs and named transformations This makes the Spark UI more developer-friendly when analyzing Overwatch runs. Job group IDs have the form <workspace name>:<OW module name> Any use of `.transform( df => df)` may be replaced with `.transformWithDescription( nt)` after instantiating a `val nt = NamedTransformation( df => df)` as its argument. This commit contains one such application of the new extension method. (See `val jobRunsAppendClusterName` in `WorkflowsTransforms.scala`.) Some logic in `GoldTransforms` falls through to elements of the special job-run-action form of Job Group IDs emitted by the platform but the impact is minimal relative to the benefit to Overwatch development and troubleshooting. Even so this form of Job Group ID is still present in initial Spark events before OW ETL modules begin to execute. commit da0c55a Author: Guenia <guenia.izquierdo@databricks.com> Date: Wed May 8 19:43:29 2024 -0400 Initial commit
Removed a level of indirection and unnecessary conditional branching in definition of chained `lookupWhen` transformations. Moved defintions to have references to `PipelineTable` objects in scope rather than passing them by argument. (cherry picked from commit efdd63f)
- enable auto-optimized shuffle for module 2011 - move caching action to previous `NamedTransformation` for more meaningful Spark UI labels
for greater visibility in Spark UI. `NamedTransformation` type name now appears in labels' second position.
prevent certain regressions when the Job Group labels set by the platform are no longer available for parsing. Labels set by the platform contain tokens that are necessary to preserve referential integrity under certain conditions. (Which conditions?)
from branch `480_workflows_support_cancelAllRuns-FUBAR` that was the original dev branch, renamed when automated merge screwed everything up.
neilbest-db
added
enhancement
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reboot of #1174 to resolve #480. After extensive refactoring in #1223, #1224, and #1253 it was necessary to abandon #1174 and bring its new logic in manually.