Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing code to derive cloud type #826

Merged
merged 1 commit into from
Mar 23, 2023
Merged

changing code to derive cloud type #826

merged 1 commit into from
Mar 23, 2023

Conversation

aman-db
Copy link
Contributor

@aman-db aman-db commented Mar 23, 2023

closes #820

@aman-db aman-db added the bug Something isn't working label Mar 23, 2023
@aman-db aman-db added this to the 0.7.2.0 milestone Mar 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@aman-db aman-db requested a review from GeekSheikh March 23, 2023 17:39
@aman-db aman-db marked this pull request as ready for review March 23, 2023 17:39
@aman-db aman-db linked an issue Mar 23, 2023 that may be closed by this pull request
Redefine the logic to derive cloud provider #820
Closed
GeekSheikh
GeekSheikh approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@GeekSheikh GeekSheikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing rapid approval to get 0720 fixed -- we will catch any issues with this during integration testing if this causes issues. But the logic makes sense to me.

@GeekSheikh GeekSheikh merged commit 7776446 into 0720_release Mar 23, 2023
@GeekSheikh GeekSheikh deleted the 820_derive_cloud_type_bug branch March 23, 2023 21:35
sudharshanraja-db pushed a commit that referenced this pull request Apr 11, 2023
@aman-db @sudharshanraja-db
changing code to derive cloud type (#826)
4de1e9a
GeekSheikh pushed a commit that referenced this pull request Apr 18, 2023
@aman-db @GeekSheikh
changing code to derive cloud type (#826)
40ee519
GeekSheikh added a commit that referenced this pull request Apr 20, 2023
@GeekSheikh @souravbaner-da
@Sourav692 @sriram251-code @aman-db @mohanbaabu1996 @gueniai
0720 Release Staging (#676)
7fa7dd8 
* rebase from main 41823

* Refractor Initializer (#683)

* initial commit

* Refractor InitializerFunctions.scala

* Refractor InitializerFunctions.scala

* Change Scala Sources Name

* Refractor InitializerFunctions.scala

* Refractor InitializerFunctions.scala

* Added Initializerv2.scala

* Added Initializerv2.scala

* Changed as per Sriram comment

* Changed as per Sriram comment

* dropped Initializer Deprecated

---------

Co-authored-by: geeksheikh <geeksheikh@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>
Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* gcp integration added (#786)

* initial commit

* Refractor Initializer (#683)

* initial commit

* Refractor InitializerFunctions.scala

* Refractor InitializerFunctions.scala

* Change Scala Sources Name

* Refractor InitializerFunctions.scala

* Refractor InitializerFunctions.scala

* Added Initializerv2.scala

* Added Initializerv2.scala

* Changed as per Sriram comment

* Changed as per Sriram comment

* dropped Initializer Deprecated

---------

Co-authored-by: geeksheikh <geeksheikh@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>
Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* gcp integration added

* gcp integration added

* minor updates from daniel

* review comment implemented

---------

Co-authored-by: geeksheikh <geeksheikh@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <109206082+souravbaner-da@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>
Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* auditlogprefix_source_aws changed to auditlogprefix_source_path (#807)

* conde changes completed

* column name changed from etl_storage_prefix to storage prefix

---------

Co-authored-by: geeksheikh <geeksheikh@users.noreply.github.com>

* upgraded sbt to current version to work with sbt and bloop build server. (#679)

Co-authored-by: Carson Wilkins <carson.wilkins@databricks.com>

* conde changes completed (#808)

* write metrics issue resolved (#813)

* code changes completed

* code changes completed

* code changes completed

* code changes completed

* changing code to derive cloud type (#826)

* audit log changes (#836)

* 837 accum updates handle nulls (#838)

* initial 0713 commit

* handled null AccumUpates

* added contextual sparkSession to DeltaTable instances (#840)

* temp_dir for MSW deployment added (#841)

* handled class not found (#848)

* Remove ClusterSpecDetailSilver Dependency from Cluster Gold (#844)

Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>

* api namespace change (#842)

* api namespace change

* review comments implemented

* added safety valve (#854)

* getParams implemented (#859)

* getParams implemented

* review comments implemented

* Slash Management (#825)

* code implemeted

* documentation added

* implemented

* review comments implemented

---------

Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* Added Logic to create PipReport (#860)

* Added Logic to create PipReport

* suggested approach for overriding signatures

* added a few enhancements

* minor updates

* removed table import and updated table referene to spark.table

---------

Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>
Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* Update azure/aws_instance_details.csv (#876)

* Update azure/aws_instance_details.csv

* Update Azure_instance_details.csv

Updated F4 to F4s for the instance Standard_F4s. Similarly for F8s and F16s.

* added pipeline_report to optimziation table list (#877)

* AAD authentication for EventHubs implemented for MWS (#872)

* AAD implemented for MWS

* review comments implemented

* AAD implemented for MWS

* review comments implemented

* review comments implemented

* review comments implemented

* review comments implemented

* updated import

---------

Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* Enable Overwatch for Unity Catalog (#811)

* adding code for uc external location and default deployment

* fixing tests

* code to enable uce deployment

* change in code to extract db location

* removed comments

* code to handle catalog reset

* change in getWorkspaceByDatabase

* removing comments

* adding default etlCatalogName and consumerCatalogName for default deployment

* adding code for uc external location and default deployment

* fixing tests

* code to enable uce deployment

* gcp integration added (#786)

* initial commit

* Refractor Initializer (#683)

* initial commit

* Refractor InitializerFunctions.scala

* Refractor InitializerFunctions.scala

* Change Scala Sources Name

* Refractor InitializerFunctions.scala

* Refractor InitializerFunctions.scala

* Added Initializerv2.scala

* Added Initializerv2.scala

* Changed as per Sriram comment

* Changed as per Sriram comment

* dropped Initializer Deprecated

---------

Co-authored-by: geeksheikh <geeksheikh@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>
Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* gcp integration added

* gcp integration added

* minor updates from daniel

* review comment implemented

---------

Co-authored-by: geeksheikh <geeksheikh@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <109206082+souravbaner-da@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>
Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* conde changes completed (#808)

* code to handle catalog reset

* Refractor Initializer (#683)

* initial commit

* Refractor InitializerFunctions.scala

* Refractor InitializerFunctions.scala

* Change Scala Sources Name

* Refractor InitializerFunctions.scala

* Refractor InitializerFunctions.scala

* Added Initializerv2.scala

* Added Initializerv2.scala

* Changed as per Sriram comment

* Changed as per Sriram comment

* dropped Initializer Deprecated

---------

Co-authored-by: geeksheikh <geeksheikh@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>
Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* adding code for uc external location and default deployment

* fixing tests

* code to enable uce deployment

* code to handle catalog reset

* fixing typo while checking existance of consumer DB

* adding code to disable db checks for uc deployment

* added query statement in the exception

* removed comments and print statements

* removed comments and print statements

* removed comments

* implemented code review comments

* added review comments

* refactored Initializer

* implemented review comments

* removed println statement

---------

Co-authored-by: Sriram Mohanty <69749553+sriram251-code@users.noreply.github.com>
Co-authored-by: geeksheikh <geeksheikh@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <109206082+souravbaner-da@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>
Co-authored-by: Daniel Tomes <10840635+GeekSheikh@users.noreply.github.com>

* Passing the apiURL to getOrgID to make it thread safe (#883)

* Instance Details Resource File Type fixes (#889)

* bad value for instanceDetails AWS fixed

* updated gcp memory to double

---------

Co-authored-by: geeksheikh <geeksheikh@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <109206082+souravbaner-da@users.noreply.github.com>
Co-authored-by: Sourav Banerjee <30810740+Sourav692@users.noreply.github.com>
Co-authored-by: Sriram Mohanty <69749553+sriram251-code@users.noreply.github.com>
Co-authored-by: carwilki <cwilkins@reonomy.com>
Co-authored-by: Carson Wilkins <carson.wilkins@databricks.com>
Co-authored-by: Aman <91308367+aman-db@users.noreply.github.com>
Co-authored-by: mohanbaabu1996 <87074323+mohanbaabu1996@users.noreply.github.com>
Co-authored-by: Guenia Izquierdo Delgado <guenia.izquierdo@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeekSheikh GeekSheikh GeekSheikh approved these changes

@sriram251-code sriram251-code Awaiting requested review from sriram251-code

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.7.2.0
Development

Successfully merging this pull request may close these issues.

Redefine the logic to derive cloud provider
2 participants
@aman-db @GeekSheikh