feat(ingest): utilities for query logs #10036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
RyanHolstien
approved these changes
Mar 12, 2024
hsheth2
added
the
merge-pending-ci
asikowitz
approved these changes
Mar 13, 2024
|
|
||
| assert dataclasses.is_dataclass(LoggedQuery) | ||
|
|
||
| shared_connection = ConnectionWrapper(pathlib.Path(query_log_file)) |
There was a problem hiding this comment.
Does this need to get closed?
There was a problem hiding this comment.
probably would be nicer to do it explicitly, but it'll get done in __del__ so it's fine
Comment on lines
+316
to
+317
| def close(self) -> None: | ||
| self._exit_stack.close() |
| @@ -126,6 +126,7 @@ def executemany( | |||
| def close(self) -> None: | |||
| for obj in self._dependent_objects: | |||
| obj.close() | |||
| self._dependent_objects.clear() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist