Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace regex approach to ls-files output parsing #544

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Replace regex approach to ls-files output parsing #544

merged 1 commit into from
Nov 26, 2023

Commits on Nov 23, 2023

  1. Replace regex approach to ls-files output parsing 

    In #540 I found about ~10% of the runtime to be attributable to the
regex-matching. This patch replaces the regex with two split()
calls. In local benchmarks I see a ~10% speedup.

One major other source of slow-down was/is the construction of
`PurePosixPath` objects. It seems this is being taken care of by
python/cpython#101362 and will be resolved
eventually.

Closes #540
    @mih
    mih committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3b01b01 View commit details
    Browse the repository at this point in the history