Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-DbaDbDataGenerator / Get-DbaRandomizedValue - Fix precision for datatime datatype #9016

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

andreasjordan
Copy link
Contributor

Please read -- recent changes to our repo

On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.

PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.

  • Please confirm you have the smaller repo (85MB .git directory vs 275MB or 110MB or 185MB .git directory)

Type of Change

  • Bug fix (non-breaking change, fixes Invoke-DbaDbDataGenerator precision to high for datatime datatype #8700 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

See issue for details.

@andreasjordan
Copy link
Contributor Author

I've used the example provided in the issue and that works now:

image

@potatoqualitee
Copy link
Member

very nice fix! Thank you 🔥

@potatoqualitee potatoqualitee merged commit de6fffc into development Jun 23, 2023
9 checks passed
@potatoqualitee potatoqualitee deleted the fix-datagenerator-new branch June 23, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoke-DbaDbDataGenerator precision to high for datatime datatype
2 participants