Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke-DbaDbLogShipping: Remove Credential from New-Item #9359

Merged
merged 1 commit into from
May 22, 2024
Merged

Invoke-DbaDbLogShipping: Remove Credential from New-Item #9359

merged 1 commit into from
May 22, 2024

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes Issue with creating new directory when Invoke-DbaDbLogShipping. #9355 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

See issue for details.

I can not test this.

wsmelton
wsmelton approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@wsmelton wsmelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because the syntax was not correct regardless

@potatoqualitee
Copy link
Member

dope thank you both 🙏🏼

@potatoqualitee potatoqualitee merged commit 9c9137d into development May 22, 2024
12 checks passed
@potatoqualitee potatoqualitee deleted the InvokeDbaDbLogShipping_fix_9355 branch May 22, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmelton wsmelton wsmelton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with creating new directory when Invoke-DbaDbLogShipping.
3 participants
@andreasjordan @potatoqualitee @wsmelton