Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-DbaAgentJobStep: Fix for using DatabaseUser #9380

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes New-DbaAgentJobStep -DatabaseUser is not setting the username for the job. #9378 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

See issue for details.

I also changed the type of the parameter Database to string like we do it in all other commands. It was already used as string inside of the command.

@potatoqualitee
Copy link
Member

LGTM 💯 🚀 ty

@potatoqualitee potatoqualitee merged commit d589743 into development Jun 6, 2024
13 checks passed
@potatoqualitee potatoqualitee deleted the NewDbaAgentJobStep_fix branch June 6, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New-DbaAgentJobStep -DatabaseUser is not setting the username for the job.
2 participants