Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security updates for SQL 2022, 2019, 2017, 2016 #9422

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

MikeyBronowski
Copy link
Contributor

@MikeyBronowski MikeyBronowski commented Jul 10, 2024

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

KB5040939 - Description of the security update for SQL Server 2022 CU13: July 9, 2024
KB5040936 - Description of the security update for SQL Server 2022 GDR: July 9, 2024
KB5040948 - Description of the security update for SQL Server 2019 CU27: July 9, 2024
KB5040986 - Description of the security update for SQL Server 2019 GDR: July 9, 2024
KB5040940 - Description of the security update for SQL Server 2017 CU31: July 9, 2024
KB5040942 - Description of the security update for SQL Server 2017 GDR: July 9, 2024
KB5040944 - Description of the security update for SQL Server 2016 SP3 Azure Connect Feature Pack: July 9, 2024
KB5040946 - Description of the security update for SQL Server 2016 SP3 GDR: July 9, 2024

Approach

Commands to test

Screenshots

Learning

@MikeyBronowski MikeyBronowski changed the title SEcurity updates for SQL 2022, 2019, 2017, 2016 Security updates for SQL 2022, 2019, 2017, 2016 Jul 10, 2024
Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

  1. Property Name Change:
    o Old Code: Uses "Name" to describe the content.
    o New Code: Uses "KBList" to describe the content.
    Improvements Needed
  2. Consistency and Clarity:
    o Ensure that all similar properties across the JSON structure follow a consistent naming convention. In this case, "KBList" should be used consistently instead of mixing with "Name" for similar purposes.
  3. Documentation:
    o Document the reason for the property name change if it addresses clarity, standardization, or aligns with external conventions.
  4. Validation:
    o Validate the JSON structure to ensure that all properties are correctly named and used according to the intended data model.
    Summary
    The change from "Name" to "KBList" appears to improve clarity and potentially aligns with a standard naming convention or data modeling requirement. Ensure consistency in naming throughout the JSON structure and document the change appropriately to maintain clarity and alignment with expected data formats or standards.

@potatoqualitee
Copy link
Member

@Imran-imtiaz48 I'm a big fan of AI, but these reviews are not helpful to us. When/if we want them, we will set them up in a pipeline with specific requirements.

@potatoqualitee
Copy link
Member

Thank you @MikeyBronowski ! feel free to ping me on slack if i dont get to this quickly enough.

@potatoqualitee potatoqualitee merged commit b36ae22 into dataplat:development Jul 16, 2024
3 checks passed
@MikeyBronowski MikeyBronowski deleted the patch-3 branch July 16, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants