Internal/fix integration tests 75 #311

MajoBerger · 2023-06-07T09:07:59Z

Phases	MP	MM	MB	MR	JM
ETA	0	0	0	0	0
Developing	0	0	0	0	0
Review	0	0	0	0	0
Total	-	-	-	-	-
ETA est.
ETA cust.	-	-	-	-	-

Problem description

Reported issues

Not-reported issues

Analysis

(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)

Problems

(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

…est-dev/DSpace into internal/fix-integration-tests-75

* Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation.

Added -fae to integration tests

…5' into internal/fix-integration-tests-75

* 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com>

* 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com>

* 102-BE/cannot-read-big-file-by-readAllBytes (#277) * replace readAllBytes * fix test errors * 103-be/shibboleth-login-wrong-error-page (#279) * The user is redireced to the FE after wrong shibboleth authentication. * Changed redirect URLs * Fixed checkstyle issues * Copied ShibbolethFilterIT into ClarinShibbolethFilterIT because the tests did must be updated. * 105-be/user-is-not-registered-after-shibboleth-login (#281) * firstname and lastname is not required for proper Shibboleth login. * Fixed IT to be failed if code is wrong * 88-BE/license-labels-are-missing-icons (#273) * License label icon can be null * user rest repository for license import * Fixed checkstyle issues * Fixed failing IT --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> * 110-be/imported-item-should-not-regenerate-certain-metadata-fields (#284) * Created test which fail when issue happens * Some metadata values are not updated during the import. * Changed logging (#286) * 116 be/deleted bitstreams cannot be imported (#296) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 80-BE/import-tasklistitem (#300) * create method and test * test runs * condition of membership * throw exception soon and explain better (#308) * added commit (#306) * 87-BE/adding-missing-attributes (#303) * add welcome_info and can_edit_submission_metadata * added missing attributes to the database * errors from review * 119-BE/remove-validation-of-deleted-bitstreams (#302) * remove validation control for deleted bitstream * added log * fix review comments * added mvn argument fail-at-end (#319) * added mvn argument fail-at-end * see mvn version * see maven version * -fae * final version of build.yml * 75-BE/missing-handles (#314) * create handle without dspace object * new controller for import handle without dspace object * create handle for workspaceitem * using of existing handle if it exists (#316) * checkstyle * fix failed test * added whitespace after for * review * removed authorization for handle creation * remove unneeded import * checkstyle * 122-be/restricted-item-download-issues (#331) * Initial commit * Remove the error when the ClarinLicense doesn't require any additional user metadata and the file cannot be downloaded because the user didn't fill in any user metadata. * The user cannot download the item with ClarinLicense that doesn't require user metadata, but controller methods required this information. * Be/fixed bitstreams added user metadata (#295) * 116-be/deleted-bitstreams-cannot-be-imported (#291) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 76-BE/import-user-metadata (#294) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * 76-BE/import-user-metadata-with-fixed-bitstream (#307) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * fix import user_metadata * fix mishmash with eperson_id and user_registration_id * create user registration and eperson separatelly, checkstyle * edited import user metadata * checkstyle --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * Removed not defined search options. (#337) * browse - Updated IT according to updated cfg (#339) * Removed not defined search options. * Updated IT according to a cfg updates. * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Removed unused class * Updated docker.yml * Updated cfg (#348) * Fixed from port 4000 to 8080 (#350) * add redeploy to dev-5 -> curl call to deploy action * add redeploy to dev-5 -> curl call to deploy action * correct redeploy branch in github action * Removed duplicate definition of the property (#353) * internal/shibboleth-missing-one-error-page * The netId is added to the user which is logged in via shibboleth. * Fixed failing integration tests. * Shib login filter returns the duplicate error * Fixed checkstyle issues * Added an email param into error response * Try to fix IT * Fixed some IT * The user is not registered if he doesn't have the email * Fixed IT - there must be unique handle * migrated-7.5/oai-is-not-working (#355) * Fixed wront `dspace.server.url` property value. * Updated scripts * Updated scripts * Fixed IT - there must be unique handle * Removed changes we don't want to have * Added empty row --------- Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk>

* 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Full BE customization for TUL (#329) * define citace pro in the config file * rename the config and add it into the default res.properties.exposed * configure the gg analytics * add email config propertyy for the contact page * add the email for lr.help.email * remove redundant email --------- Co-authored-by: HuynhKhoa1601 <huynhnhatkhoa21@gmail.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com> * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Removed unused class * Updated docker.yml * Updated cfg (#348) * Fixed from port 4000 to 8080 (#350) * add redeploy to dev-5 -> curl call to deploy action * add redeploy to dev-5 -> curl call to deploy action * correct redeploy branch in github action * Removed duplicate definition of the property (#353) * internal/shibboleth-missing-one-error-page * The netId is added to the user which is logged in via shibboleth. * Fixed failing integration tests. * Shib login filter returns the duplicate error * Fixed checkstyle issues * Added an email param into error response * Try to fix IT * Fixed some IT * The user is not registered if he doesn't have the email * Fixed IT - there must be unique handle * migrated-7.5/oai-is-not-working (#355) * Fixed wront `dspace.server.url` property value. * Updated scripts * Updated scripts * Fixed IT - there must be unique handle * Removed changes we don't want to have * Added empty row * Commented out TUL properties (#359) * trigger docker images on correct branch * internal/fix-discojuice-issues (#371) * Added property to disable or allow the discojuice. Fixed cronjob interval for 2 hours. Changed Discojuice logs to DEBUG. * Fixed discojuice interval * In some cases the log shouldn't be in debug mode, but in the error --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: HuynhKhoa1601 <huynhnhatkhoa21@gmail.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com>

* 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Full BE customization for TUL (#329) * define citace pro in the config file * rename the config and add it into the default res.properties.exposed * configure the gg analytics * add email config propertyy for the contact page * add the email for lr.help.email * remove redundant email --------- Co-authored-by: HuynhKhoa1601 <huynhnhatkhoa21@gmail.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com> * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Removed unused class * Updated docker.yml * Updated cfg (#348) * Fixed from port 4000 to 8080 (#350) * add redeploy to dev-5 -> curl call to deploy action * add redeploy to dev-5 -> curl call to deploy action * correct redeploy branch in github action * Removed duplicate definition of the property (#353) * internal/shibboleth-missing-one-error-page * The netId is added to the user which is logged in via shibboleth. * Fixed failing integration tests. * Shib login filter returns the duplicate error * Fixed checkstyle issues * Added an email param into error response * Try to fix IT * Fixed some IT * The user is not registered if he doesn't have the email * Fixed IT - there must be unique handle * migrated-7.5/oai-is-not-working (#355) * Fixed wront `dspace.server.url` property value. * Updated scripts * Updated scripts * Fixed IT - there must be unique handle * Removed changes we don't want to have * Added empty row * Merge actual 7.5. version into TUL (#357) * 102-BE/cannot-read-big-file-by-readAllBytes (#277) * replace readAllBytes * fix test errors * 103-be/shibboleth-login-wrong-error-page (#279) * The user is redireced to the FE after wrong shibboleth authentication. * Changed redirect URLs * Fixed checkstyle issues * Copied ShibbolethFilterIT into ClarinShibbolethFilterIT because the tests did must be updated. * 105-be/user-is-not-registered-after-shibboleth-login (#281) * firstname and lastname is not required for proper Shibboleth login. * Fixed IT to be failed if code is wrong * 88-BE/license-labels-are-missing-icons (#273) * License label icon can be null * user rest repository for license import * Fixed checkstyle issues * Fixed failing IT --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> * 110-be/imported-item-should-not-regenerate-certain-metadata-fields (#284) * Created test which fail when issue happens * Some metadata values are not updated during the import. * Changed logging (#286) * 116 be/deleted bitstreams cannot be imported (#296) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 80-BE/import-tasklistitem (#300) * create method and test * test runs * condition of membership * throw exception soon and explain better (#308) * added commit (#306) * 87-BE/adding-missing-attributes (#303) * add welcome_info and can_edit_submission_metadata * added missing attributes to the database * errors from review * 119-BE/remove-validation-of-deleted-bitstreams (#302) * remove validation control for deleted bitstream * added log * fix review comments * added mvn argument fail-at-end (#319) * added mvn argument fail-at-end * see mvn version * see maven version * -fae * final version of build.yml * 75-BE/missing-handles (#314) * create handle without dspace object * new controller for import handle without dspace object * create handle for workspaceitem * using of existing handle if it exists (#316) * checkstyle * fix failed test * added whitespace after for * review * removed authorization for handle creation * remove unneeded import * checkstyle * 122-be/restricted-item-download-issues (#331) * Initial commit * Remove the error when the ClarinLicense doesn't require any additional user metadata and the file cannot be downloaded because the user didn't fill in any user metadata. * The user cannot download the item with ClarinLicense that doesn't require user metadata, but controller methods required this information. * Be/fixed bitstreams added user metadata (#295) * 116-be/deleted-bitstreams-cannot-be-imported (#291) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 76-BE/import-user-metadata (#294) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * 76-BE/import-user-metadata-with-fixed-bitstream (#307) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * fix import user_metadata * fix mishmash with eperson_id and user_registration_id * create user registration and eperson separatelly, checkstyle * edited import user metadata * checkstyle --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * Removed not defined search options. (#337) * browse - Updated IT according to updated cfg (#339) * Removed not defined search options. * Updated IT according to a cfg updates. * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script …

* Tul/tmp 4 merge (#401) * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Full BE customization for TUL (#329) * define citace pro in the config file * rename the config and add it into the default res.properties.exposed * configure the gg analytics * add email config propertyy for the contact page * add the email for lr.help.email * remove redundant email --------- Co-authored-by: HuynhKhoa1601 <huynhnhatkhoa21@gmail.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com> * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Removed unused class * Updated docker.yml * Updated cfg (#348) * Fixed from port 4000 to 8080 (#350) * add redeploy to dev-5 -> curl call to deploy action * add redeploy to dev-5 -> curl call to deploy action * correct redeploy branch in github action * Removed duplicate definition of the property (#353) * internal/shibboleth-missing-one-error-page * The netId is added to the user which is logged in via shibboleth. * Fixed failing integration tests. * Shib login filter returns the duplicate error * Fixed checkstyle issues * Added an email param into error response * Try to fix IT * Fixed some IT * The user is not registered if he doesn't have the email * Fixed IT - there must be unique handle * migrated-7.5/oai-is-not-working (#355) * Fixed wront `dspace.server.url` property value. * Updated scripts * Updated scripts * Fixed IT - there must be unique handle * Removed changes we don't want to have * Added empty row * Merge actual 7.5. version into TUL (#357) * 102-BE/cannot-read-big-file-by-readAllBytes (#277) * replace readAllBytes * fix test errors * 103-be/shibboleth-login-wrong-error-page (#279) * The user is redireced to the FE after wrong shibboleth authentication. * Changed redirect URLs * Fixed checkstyle issues * Copied ShibbolethFilterIT into ClarinShibbolethFilterIT because the tests did must be updated. * 105-be/user-is-not-registered-after-shibboleth-login (#281) * firstname and lastname is not required for proper Shibboleth login. * Fixed IT to be failed if code is wrong * 88-BE/license-labels-are-missing-icons (#273) * License label icon can be null * user rest repository for license import * Fixed checkstyle issues * Fixed failing IT --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> * 110-be/imported-item-should-not-regenerate-certain-metadata-fields (#284) * Created test which fail when issue happens * Some metadata values are not updated during the import. * Changed logging (#286) * 116 be/deleted bitstreams cannot be imported (#296) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 80-BE/import-tasklistitem (#300) * create method and test * test runs * condition of membership * throw exception soon and explain better (#308) * added commit (#306) * 87-BE/adding-missing-attributes (#303) * add welcome_info and can_edit_submission_metadata * added missing attributes to the database * errors from review * 119-BE/remove-validation-of-deleted-bitstreams (#302) * remove validation control for deleted bitstream * added log * fix review comments * added mvn argument fail-at-end (#319) * added mvn argument fail-at-end * see mvn version * see maven version * -fae * final version of build.yml * 75-BE/missing-handles (#314) * create handle without dspace object * new controller for import handle without dspace object * create handle for workspaceitem * using of existing handle if it exists (#316) * checkstyle * fix failed test * added whitespace after for * review * removed authorization for handle creation * remove unneeded import * checkstyle * 122-be/restricted-item-download-issues (#331) * Initial commit * Remove the error when the ClarinLicense doesn't require any additional user metadata and the file cannot be downloaded because the user didn't fill in any user metadata. * The user cannot download the item with ClarinLicense that doesn't require user metadata, but controller methods required this information. * Be/fixed bitstreams added user metadata (#295) * 116-be/deleted-bitstreams-cannot-be-imported (#291) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 76-BE/import-user-metadata (#294) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * 76-BE/import-user-metadata-with-fixed-bitstream (#307) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * fix import user_metadata * fix mishmash with eperson_id and user_registration_id * create user registration and eperson separatelly, checkstyle * edited import user metadata * checkstyle --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * Removed not defined search options. (#337) * browse - Updated IT according to updated cfg (#339) * Removed not defined search options. * Updated IT according to a cfg updates. * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervis…

* 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Full BE customization for TUL (#329) * define citace pro in the config file * rename the config and add it into the default res.properties.exposed * configure the gg analytics * add email config propertyy for the contact page * add the email for lr.help.email * remove redundant email --------- Co-authored-by: HuynhKhoa1601 <huynhnhatkhoa21@gmail.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com> * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Removed unused class * Updated docker.yml * Updated cfg (#348) * Fixed from port 4000 to 8080 (#350) * add redeploy to dev-5 -> curl call to deploy action * add redeploy to dev-5 -> curl call to deploy action * correct redeploy branch in github action * Removed duplicate definition of the property (#353) * internal/shibboleth-missing-one-error-page * The netId is added to the user which is logged in via shibboleth. * Fixed failing integration tests. * Shib login filter returns the duplicate error * Fixed checkstyle issues * Added an email param into error response * Try to fix IT * Fixed some IT * The user is not registered if he doesn't have the email * Fixed IT - there must be unique handle * migrated-7.5/oai-is-not-working (#355) * Fixed wront `dspace.server.url` property value. * Updated scripts * Updated scripts * Fixed IT - there must be unique handle * Removed changes we don't want to have * Added empty row * Commented out TUL properties (#359) * trigger docker images on correct branch * internal/fix-discojuice-issues (#371) * Added property to disable or allow the discojuice. Fixed cronjob interval for 2 hours. Changed Discojuice logs to DEBUG. * Fixed discojuice interval * In some cases the log shouldn't be in debug mode, but in the error --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: HuynhKhoa1601 <huynhnhatkhoa21@gmail.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com>

* Tul/tmp 4 merge (#401) * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Full BE customization for TUL (#329) * define citace pro in the config file * rename the config and add it into the default res.properties.exposed * configure the gg analytics * add email config propertyy for the contact page * add the email for lr.help.email * remove redundant email --------- Co-authored-by: HuynhKhoa1601 <huynhnhatkhoa21@gmail.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com> * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Removed unused class * Updated docker.yml * Updated cfg (#348) * Fixed from port 4000 to 8080 (#350) * add redeploy to dev-5 -> curl call to deploy action * add redeploy to dev-5 -> curl call to deploy action * correct redeploy branch in github action * Removed duplicate definition of the property (#353) * internal/shibboleth-missing-one-error-page * The netId is added to the user which is logged in via shibboleth. * Fixed failing integration tests. * Shib login filter returns the duplicate error * Fixed checkstyle issues * Added an email param into error response * Try to fix IT * Fixed some IT * The user is not registered if he doesn't have the email * Fixed IT - there must be unique handle * migrated-7.5/oai-is-not-working (#355) * Fixed wront `dspace.server.url` property value. * Updated scripts * Updated scripts * Fixed IT - there must be unique handle * Removed changes we don't want to have * Added empty row * Merge actual 7.5. version into TUL (#357) * 102-BE/cannot-read-big-file-by-readAllBytes (#277) * replace readAllBytes * fix test errors * 103-be/shibboleth-login-wrong-error-page (#279) * The user is redireced to the FE after wrong shibboleth authentication. * Changed redirect URLs * Fixed checkstyle issues * Copied ShibbolethFilterIT into ClarinShibbolethFilterIT because the tests did must be updated. * 105-be/user-is-not-registered-after-shibboleth-login (#281) * firstname and lastname is not required for proper Shibboleth login. * Fixed IT to be failed if code is wrong * 88-BE/license-labels-are-missing-icons (#273) * License label icon can be null * user rest repository for license import * Fixed checkstyle issues * Fixed failing IT --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> * 110-be/imported-item-should-not-regenerate-certain-metadata-fields (#284) * Created test which fail when issue happens * Some metadata values are not updated during the import. * Changed logging (#286) * 116 be/deleted bitstreams cannot be imported (#296) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 80-BE/import-tasklistitem (#300) * create method and test * test runs * condition of membership * throw exception soon and explain better (#308) * added commit (#306) * 87-BE/adding-missing-attributes (#303) * add welcome_info and can_edit_submission_metadata * added missing attributes to the database * errors from review * 119-BE/remove-validation-of-deleted-bitstreams (#302) * remove validation control for deleted bitstream * added log * fix review comments * added mvn argument fail-at-end (#319) * added mvn argument fail-at-end * see mvn version * see maven version * -fae * final version of build.yml * 75-BE/missing-handles (#314) * create handle without dspace object * new controller for import handle without dspace object * create handle for workspaceitem * using of existing handle if it exists (#316) * checkstyle * fix failed test * added whitespace after for * review * removed authorization for handle creation * remove unneeded import * checkstyle * 122-be/restricted-item-download-issues (#331) * Initial commit * Remove the error when the ClarinLicense doesn't require any additional user metadata and the file cannot be downloaded because the user didn't fill in any user metadata. * The user cannot download the item with ClarinLicense that doesn't require user metadata, but controller methods required this information. * Be/fixed bitstreams added user metadata (#295) * 116-be/deleted-bitstreams-cannot-be-imported (#291) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 76-BE/import-user-metadata (#294) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * 76-BE/import-user-metadata-with-fixed-bitstream (#307) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * fix import user_metadata * fix mishmash with eperson_id and user_registration_id * create user registration and eperson separatelly, checkstyle * edited import user metadata * checkstyle --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * Removed not defined search options. (#337) * browse - Updated IT according to updated cfg (#339) * Removed not defined search options. * Updated IT according to a cfg updates. * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Mohamed Saber Eskander <mohamed.eskander@4science.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: jensroets <jens.roets@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: jensvannerum <78496674+jensvannerum@users.noreply.github.com> Co-authored-by: Mykhaylo <michele.boychuk@gmail.com> Co-authored-by: Francesco Pio Scognamiglio <francescopio.scognamiglio@4science.it> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Pascal-Nicolas Becker <dspace@pascal-becker.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Raf Ponsaerts <raf.ponsaerts@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervis…

* Created README-dtq.md * Created approximateDate local metadata type. * Added test to check existing metadata but doesn't works right * Created test for added local metadata if exists. * Update ItemTest.java Remove dtqExampleTest * update issue assign action with new token * upload github workflows - build and publish images on dtq-dev-present branch * Created ACL and ACE classes * ACL works - input field with ACL are rendered based on the authorization. * Created tests for ACL * Fixed checkstyle issues * Remove unnecessary methods * Authorization based on groups works and done some refactoring. * Added authors * Fixed review issues * Fixed checkstyle issues * Removed unsused acl definition in the input field * added missing lib to the Dockerfile.cli * fixed adding of missing lib to the Dockerfile.cli * fixed harvester dependencies * removed xalan.jar from dspace/lib folder * removed xalan dependency duplicities * Changed upload file size to 3GB * Created a new local type and added a new input field for the bitstream URL * The file is loaded from the tomcat /temp and updated as bitstream * uploadFileFromURL must be in the end of the patch method because the local.bitstream.redirectToURL metadata must be saved in the DB before asking for that value. * fixed checkstyle violation * created test uploadFileBiggerThanUploadFileSizeLimit * created test uploadFileBiggerThanUploadFileSizeLimit * Remvoed checkstyle violations * Added docs * Added empty row * remove unsued dependency from pom * refacroting * Done requested changes * fixed checkstyle violations * Added build scripts * don't hold local paths in repo, better names for build scripts * fix last * updated script names * Separated config files, reverted dspace.cfg to original, introduced clarin-dspace.cfg: (#80) * Separated config files, reverted dspace.cfg to original: * Must be called dspace.name = DSpace at My University or tests will fail * cleared up clarin-dspace.cfg * added link to future changes from the past clarin config * For some items the date of creation is unknown or in date range. Problem description For some items the date of creation is unknown or in date range. This information is stored in the approximateDate metadata. If approximateDate metadata is not null -> show value from this metadata instead of date issued. * Show funding suggestions for EU projects - openAIRE and non-EU projects. Suggestions are showed in the complex input field. ## Problem description Show funding suggestions for EU projects - openAIRE and non-EU projects. Suggestions are showed in the complex input field. - [x] If should return suggestions for the non eu sponsors do not return eu suggestions - [x] distinct suggestions - if the sponsor exist in more items the API return the same suggestion several times - [x] openAIRE oai-pmh return only the items with eu-identifier **!!!** This pull request contains pull request for _complex-input-types_ and _autocomplete_ **!!!** **complex-input-types:** https://github.com/dataquest-dev/DSpace/pull/44 **autocomplete:** https://github.com/dataquest-dev/DSpace/pull/50 **Commits:** * Added configuration for the complex input type, complex input type is NOT send to the request. * Fixed checkstyle issues * Return empty complexDefinition in the response * complex definition is processed * COMPLEX_DEFINITION_REF added to the formDefns * Return complexDefinition as JSON string * Created unit tests for the new local metadata types * Created unit tests for the DCInput.java * Fixed checkstyle issues * Moved a new files to the dspace packages * Added docs * Added docs * Edited docs * removed empty row * Commented complex input type using in the submission-forms.xml * Removed empty row * Added metadata validation for the complex input definition and transformed complex definition into json is ordered * Fixed checkstyle issues * set series to not required * fixed issue after resolved conflicts * fixed checkstyle issue * Defined autocomplete tag * Autocomplete definition is exposed in the form definition response * Created example new REST API * Endpoint is returning searched metadata values * created endpoint /metadatavalues but it throws strange error * Created wrapper for MetadataValue with converter, resource, repository * Created functionality to return all metadataValues * Added some docs * Added some docs and removed autocomplete definition from the submission-forms.dtd * Removed autocomplete tag * added empty row * Refactoring * Created IT for MetadataValueRestRepository * Removed unused code * Changed docs * Removed autocomplete comment * changed method which create json from complex definition. * refactoring * fixed checkstyle violations * changed expected json in the test * added funding complex type * Fixed empty N/A stored value * EU sponsor is added to the dc.relation * Added doc * fixed difference error between add and replace operation * fixed eu prefix null error * Fixed error: cannot call replace method on empty metadata * Created some tests for OpenAIRE * Created some tests for OpenAIRE and fixed some errors * Finish open-aire complex definition tests for storing information in more metadata fields * Removed duplicities in suggestions and do not return eu sponsors as suggestions. * Fixed local.bistream.redirectsToURL test error - schema tag was removed in the conflict * Fixed checkstyle violations * One test should throw exception but didn't - fixed * Fixed change requests * Refactoring Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * Internal/generate bat for tests (#94) * Added generating test scripts * fixed misleading comment * added maven source to our readme * fixed minor incoviniences while generating tests * added pause to scripts * Added newline to end of two scripts * improved description, changed generated filenames * dispatch images build * feature/se-2-type-bind-upstream. Copied from DSpace - 7.3. * Loaded code from the upstream * Loaded code from the upstream to fix errors * Loaded another code from the upstream to fix errors * Revert changes * Copied type-bind code from the upstream main * Fixed wrong formatting * Copied test correctly * Fixed test errors * Loaded submission forms from main * Some fixes * Fixed missing ACL * Created tests to check if is not converted admin input field for the user. Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/se-11-improvements-after-testing changed configuration file, property, hints * Uploaded big file hint and label * The uploaded big file is deleted after upload and added property to decide if should be deleted uploaded file * Update dspace.cfg * Changed property name * property added to the clarin-dspace.cfg Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/se-9-upload-CMDI upload the cmdi file to the METADATA bundle * Added a new local metadata type - hasCMDI * CMDI file is uploaded to the right bundle * From method o maintain cmdi file was created Util class * Changed values of input field for local metadata hasCMDI * Fixed checkstyle issues * Created tests for the CMDIFileBundleMaintainer * Fixed checkstyle issues and removed unnecessary code. * Added documentation and removed some unnecessary code * Fixed checkstyle issues * Updated cmdi file maintaining method because it failed when the hasCMDI metadata was null * fixed error of getting item from the empty array * Removed empty row * Changed hasUploadFiles method and upload validation * Light code refactoring * Fixed error which was created by resolving conflicts * Fixed error which was created by resolving conflicts * Done review changes * changed sign * Refactor if statement Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * Load files from METADATA bundle in the removing file. Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/se-4-autocomplete-bad-behavior update solr queries if the search expression consist of nums and chars * Initial commit * Separating characters and numbers from the searchValue. * Fixed wrong autocomplete suggestions Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/se-6-non-eu-funds-not-suggested MetadataValueRestRepository searched only in Items not WorkspaceItems Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * fixed generating proper unit tests (#129) * internal/upgrade-building-script (#109) * script for deleting test environment * implementation of comments after review * edited example file * feature/pid-7-tombstone added metadata and changed Converter * Initial commit * Created helpDesk Controller and added help-desk mail to the configuration * Updated ItemConverter to return necessary metadata for the tombstone. * Removed HelpDesk Controller the mail is exposed by the ConfigurationController * Uncomment complex input fields Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * added nginx redirect and instructions to wiki (#110) * Using dataquest, not dspace image as a base * added MP to PR templates * skip overwrite prompt in our script * United/clarin oai formats cmdi, olac, oai extensions,.. * Added openaire context and data format from clarin-dspace * added distinct * added test support for OAI-PMH (MockSolrOAICore) * added OAIMPH test * attempted transforming XOAI.java into bean * modify IT for Openaire OAI * added files for cmdi format * adding cmdi format - rewriting java functions * fixed functions for clarin cmdi format * new url, correct document for cmdi * sacrifice to the checkstyle god * added /cmdi/oai-metadata endpoint * sacrifice to the checkstyle god * replaced distinct with custom function * build speed-up maven build speed Co-authored-by: kshepherd <kim@shepherd.nz> * Initial commit * added olac format * added type and test * fixed generating proper unit tests * local.hidden support * changed local.hidden to local.hiddenButHarvestable; adjusted local.hasMetadata to local.hasCMDI, set deleted to false in xoai on localButHidde * modified hidden input box * changes in oai_dc.xsl * edits after tests * safety check, changes after tests * replaced distinct function with working version * replace fn:distinct with distinct-values * fixed tests * cleaning useless files * removing comments and useless classes * PR clean-up 4 * fixes to metasharev2 OAI metadataFormat * removed redundant spaces, added newlines at ends of files * fixes, PR * PR fixes 2 * added last missing source * fixed error - whitespace at end of line * skip overwrite prompt in our script * used wrong method Co-authored-by: kshepherd <kim@shepherd.nz> Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/pid-4-config-handle-for-communities waiting for EPIC consortium and Handle.net registration * Init commit * loaded community prefix definition from configuration * error initializing database * new classes removed * loaded community configurations and created tests * added PID service, problem with database * fixed gititnore for /scripts/ * added script forhandle url column in database * Added alter table Handle to the m2 migration * added PIDService * set handle of local item * epic configuration (in progress) * Created ExternalHandleRestRepository * Created Dump for the Handles with magicURL * added comments * checkstyle * Created external.Handle class, updated HandlePlugin - added repositoryName, added endpoint to get all External Handles * working on tests * Maybe created update operation * created magicLindat funcionality * Removed HandleDAO Clarin * Some refactoring * Some refactoring * Some refactoring * refactoring done * some refactoring * disable test unless the epic consortium will be configured * PIDs associated to metadata * fixed checkstyle issues * Ignore test * Added external handle license header * Refactoring and caught potential exceptions Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * feature/pid-5-manage-handle-table handle administration, change global prefix * creation of new handle classes * Integration test for HandleRestRepository * Checkstyle * Trying to solve strange error * change from DSpaceObject to DSpaceObjectRest * Problem with missing constructor resolved * Tiny stability fix to test (fails on Windows). Remove newline from string comparison (#82) Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> * implementation of new methods * tests findAll and deleteSuccess from HandleRestRepositoryIT failed * checkstyle * Fixed strange error * handle modification and prefix change; deleteSuccess test does not work * fix for delete item test * changing patch value from hashMap to string * added comments * added adminToken in handle findAll test * Removed DSpaceObject from Handle attribute and from the HandleConverter because converting DSpaceObject takes too long. * Removed DSpaceObject from Handle attribute and from the HandleConverter because converting DSpaceObject takes too long. * Changed some endpoints - create to createAndReturn * added script to update Handle table * incorporating comments * script for deleting tests environment * build speed-up maven build speed Co-authored-by: kshepherd <kim@shepherd.nz> * edited replace handle * editing set prefix * change of all handles when changing the prefix * update tests; update method names * fixed archiving * added comments, tests and fixed methods according to comments * run tests, added input control * wrong creating url in archiving * Working on sorting * Sorting worked * Sorting worked * Added docs * Added docs and done some refactoring * Some refactoring * Removed empty row * Fixed checkstyle violations * Fixed IT test * Fixed IT for HandleRestRepositoryIT * Added descriptive comment for HandleClarinService * fixed checkstyle violations after merge * Fixed IT tests Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: kshepherd <kim@shepherd.nz> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * Feature/pid-5-manage-handle-table-errors-correction (#155) * fix edit internal handle * test fixes * tests * comments and check style * Milan's review * error condition * edited errors in HandleClarinServiceImplIT * feature/pid-5-fixed-handle-table-pagination (#158) and sorting * Fixed handle table pagination * last I checkout not up to date code Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/dtq-dev-lf (#161) licensing framework * Feature/lf 4 license administrator-2-dtq-dev-tmp (#150) * Initial commit * Added some ClarinLicense classes * Added some ClarinLicense classes * Added some ClarinLicense classes * Created ClarinLicenseLabelList and other classes. It throws ClassNotFound exception * Clarin License has ClarinLicenseLabel classes in the response * Return the clarinLicense with extended labels and another custom data * Return the clarinLicense with extended labels and another custom data * Created findAll method in the ClarinLicenseLabelRestRepository * Cannot map HashMap to the ClarinLicenseRest * Created Endpoint and test for defining a new clarin license * Created Endpoint and tests for Deleting the Clarin Licenses * Created endpoint for updating licenses with tests * Created endpoint for creating Clarin License Labels with tests * Added docs * fixed checkstyle violations Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/lf-4-license-administrator dtq-dev-lf * Initial commit * Added some ClarinLicense classes * Added some ClarinLicense classes * Added some ClarinLicense classes * Created ClarinLicenseLabelList and other classes. It throws ClassNotFound exception * Clarin License has ClarinLicenseLabel classes in the response * Return the clarinLicense with extended labels and another custom data * Return the clarinLicense with extended labels and another custom data * Created findAll method in the ClarinLicenseLabelRestRepository * Cannot map HashMap to the ClarinLicenseRest * Created Endpoint and test for defining a new clarin license * Created Endpoint and tests for Deleting the Clarin Licenses * Created endpoint for updating licenses with tests * Created endpoint for creating Clarin License Labels with tests * Added docs * fixed checkstyle violations * added license header * feature/lf-4 license-admin-another-tables created the resource mapping and make counting license bitstreams * created clarin license resource mapping * error with integration tests - active transaction * checkout from license administrator * tests not working * checkout with feature/lf-4-license-administrator * The bitstream is mapped to the license * The bitstream is mapped to the license in the IT too * a little refactoring Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * fixed checkstyle violations and added header to the new classes * feature/lf-4-license-admin-fixed-null-error * init commit * mapping new tables * Fixed clarin null bitstream exception * Commented new table classes * Added license headers * Fixed checkstyle violation * Fixed external handle rest repository IT failing tests - created HandleClarinBuilder * Fixed checkstyle violations Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * Feature/lf 4 license administrator-2-dtq-dev-tmp (#150) * Initial commit * Added some ClarinLicense classes * Added some ClarinLicense classes * Added some ClarinLicense classes * Created ClarinLicenseLabelList and other classes. It throws ClassNotFound exception * Clarin License has ClarinLicenseLabel classes in the response * Return the clarinLicense with extended labels and another custom data * Return the clarinLicense with extended labels and another custom data * Created findAll method in the ClarinLicenseLabelRestRepository * Cannot map HashMap to the ClarinLicenseRest * Created Endpoint and test for defining a new clarin license * Created Endpoint and tests for Deleting the Clarin Licenses * Created endpoint for updating licenses with tests * Created endpoint for creating Clarin License Labels with tests * Added docs * fixed checkstyle violations Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/lf-4-license-administrator dtq-dev-lf * Initial commit * Added some ClarinLicense classes * Added some ClarinLicense classes * Added some ClarinLicense classes * Created ClarinLicenseLabelList and other classes. It throws ClassNotFound exception * Clarin License has ClarinLicenseLabel classes in the response * Return the clarinLicense with extended labels and another custom data * Return the clarinLicense with extended labels and another custom data * Created findAll method in the ClarinLicenseLabelRestRepository * Cannot map HashMap to the ClarinLicenseRest * Created Endpoint and test for defining a new clarin license * Created Endpoint and tests for Deleting the Clarin Licenses * Created endpoint for updating licenses with tests * Created endpoint for creating Clarin License Labels with tests * Added docs * fixed checkstyle violations * added license header * feature/lf-4 license-admin-another-tables created the resource mapping and make counting license bitstreams * created clarin license resource mapping * error with integration tests - active transaction * checkout from license administrator * tests not working * checkout with feature/lf-4-license-administrator * The bitstream is mapped to the license * The bitstream is mapped to the license in the IT too * a little refactoring Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * fixed checkstyle violations and added header to the new classes * feature/lf-4-license-admin-fixed-null-error * init commit * mapping new tables * Fixed clarin null bitstream exception * Commented new table classes * Added license headers * Fixed checkstyle violation * Fixed external handle rest repository IT failing tests - created HandleClarinBuilder * Fixed checkstyle violations Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * feature/dtq-dev-lf (#159) * Initial commit * Added some ClarinLicense classes * Added some ClarinLicense classes * Added some ClarinLicense classes * Created ClarinLicenseLabelList and other classes. It throws ClassNotFound exception * Clarin License has ClarinLicenseLabel classes in the response * Return the clarinLicense with extended labels and another custom data * Return the clarinLicense with extended labels and another custom data * Created findAll method in the ClarinLicenseLabelRestRepository * Cannot map HashMap to the ClarinLicenseRest * Created Endpoint and test for defining a new clarin license * Created Endpoint and tests for Deleting the Clarin Licenses * Created endpoint for updating licenses with tests * Created endpoint for creating Clarin License Labels with tests * Added docs * fixed checkstyle violations * added license header * feature/lf-4 license-admin-another-tables created the resource mapping and make counting license bitstreams * created clarin license resource mapping * error with integration tests - active transaction * checkout from license administrator * tests not working * checkout with feature/lf-4-license-administrator * The bitstream is mapped to the license * The bitstream is mapped to the license in the IT too * a little refactoring Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * fixed checkstyle violations and added header to the new classes * feature/lf-4-license-admin-fixed-null-error * init commit * mapping new tables * Fixed clarin null bitstream exception * Commented new table classes * Added license headers * Fixed checkstyle violation * Fixed external handle rest repository IT failing tests - created HandleClarinBuilder * Fixed checkstyle violations Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * Feature/lf 3 license selector (#160) * Initial commit * Initial commit * feature/lf-3-license-selector-from dev-lf added license admin features (#153) * Initial commit * Added some ClarinLicense classes * Added some ClarinLicense classes * Added some ClarinLicense classes * Created ClarinLicenseLabelList and other classes. It throws ClassNotFound exception * Clarin License has ClarinLicenseLabel classes in the response * Return the clarinLicense with extended labels and another custom data * Return the clarinLicense with extended labels and another custom data * Created findAll method in the ClarinLicenseLabelRestRepository * Cannot map HashMap to the ClarinLicenseRest * Created Endpoint and test for defining a new clarin license * Created Endpoint and tests for Deleting the Clarin Licenses * Created endpoint for updating licenses with tests * Created endpoint for creating Clarin License Labels with tests * Added docs * fixed checkstyle violations * added license header * feature/lf-4 license-admin-another-tables created the resource mapping and make counting license bitstreams * created clarin license resource mapping * error with integration tests - active transaction * checkout from license administrator * tests not working * checkout with feature/lf-4-license-administrator * The bitstream is mapped to the license * The bitstream is mapped to the license in the IT too * a little refactoring Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * fixed checkstyle violations and added header to the new classes * feature/lf-4-license-admin-fixed-null-error * init commit * mapping new tables * Fixed clarin null bitstream exception * Commented new table classes * Added license headers * Fixed checkstyle violation * Fixed external handle rest repository IT failing tests - created HandleClarinBuilder * Fixed checkstyle violations Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * Clarin license step * Added validation to the license and fixed error if is uploading the bigfile * Little refactoring and fixed deleting clarin license resource mapping, it won't try to delete child bitstream * Create Clarin License Not Found Exception * Find the clarin license by name via clarin license endpoint and updated clarin license not found exception * The clarin license step was divided to two steps: distribution license and resource license step Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> * Fixed error if the clarin license rest id null and used bitstreams info added to the license table * Update docker.yml * Update docker.yml * Do not change the clarin license label id in creating. * removed required complex input fields * removed authorization for finding all license labels * feature/lf-6-license-search-filter updated discovery.xml * Initial commit * Initial commit * Added search filter rights * refactored added filter Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * The license is added to the bitstream in importing metadata and clarin license returns count of the non deleted bitstreams. * Fixed adding clarin license to the bitstream in the method `addBitstream` and created some tests for it. * Created tests for the uploading the bitstreams and maintaining the clarin licenses * Little refactoring * Added test to check if was attached clarin license to the item metadata in the patch method * Create ClarinWorkspaceItemRestRepositoryIT for our WorkspaceItem tests. Created integration tests for maintaining clarin license in the item's metadata and workspace item bitstream. * Little refactoring: added license headers to the new classes, added docs. * Fixed checkstyle violations * Do not build a new docker image in github action * fixed some integration tests * Fixed integraton tests - added clarin distribution license required validation configuration property * fixed checkstyle violations * feature/lf-4-mapping-of-other-tables bitstream downloads * ClarinUserRegistration * connection with database does not work * solver error with database * mapping of user_metadata and license_resource_user_allowance, error: ClarinUserRegistrationBuilder.createClarinUserRegistration return valu null * Created the main method to authorize bitstreams * Services added to the xml bean definitoins. App si runnable * /authrn endpoint works * wroking on the Auth Controller * Create first version of authorizing the bitstream download * Mapped some java classes * Added verifying token * checkstyle * Created test to download bitstream by token * Created test for authorization the bitstream downloads * Added permissions for the endpoint * tests errors * service tests work * Download Authorization system works * Created repositories and REST classes for licensing framework another tables. Created mapping CLRUA with resource mapping, user metadata and user registration. * Load userMetadata, userRegistration, resourceMapping for signed in and non signed in user. * Finished bitstream downloading and fixed some error for licenses. * Some refactoring changes * Some refactoring changes Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * Changed Clarin messages to CLARIN * Added comment why we commented LicenseValidation * Fixed null pointer exception. Reason: the ITCommunityCollection call without HTTPRequest AuthorizeBitstreamUtils but it is expecting HTTPRequest * Fixed integration tests Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> * internal/fix-lf-checkstyle-issues (#176) * Fixed checkstyle issues * Added license to the class headers Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * internal/fix-failing-unit-test - wrong unit test Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/aai-6-federated-login (#166) discojuice * Created DiscoJuiceFeeds Controller with integration tests. * fixed checkstyle issues * Fixed crashing unit tests - problem was in the ClarinLicenseResourceUserAllowanceDAOImplTest class - method destroy() * The discojuice feeds are downloading by the CRON job. * Changed the cron job definition for spring boot * Fixed checkstyle issues * Added license headers * Trying to fix the ClarinDiscoJuiceFeedsControllerIT * Fixed the ClarinDiscoJuiceFeedsControllerIT the test file is loaded in the different way. * Fixed response string - removed UTF-8 chars. Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/aai-2-missing-idp-headers (#169) * Initial commit * Send the email to the user with autoregistration link. * Created verification token table and authorization the user by that token. * Created Clarin classes for custom Shibboleth authentication. * Created clarin verification token REST, Repository, Converter * Added log error message * The user is automatically logged in after Shibboleth authentication. * The user is authenticated in the filter if the IDP has sent all headers without email and eperson exist in the table. * Revert changes in the ShibAuthentication class * Added docs to the ClarinShibAuthentication * Added docs to the ShibHeaders, ShibAuthentication, Headers, ClarinVerificationToken * Added doc to the ClarinVerificationTokenService * Added doc to the ClarinVerificationTokenServiceImpl * Added doc to the ClarinVerificationTokenDAO and ClarinVerificationTokenDAOImpl * Added docs for the ShibHeadersTest * Added docs for the ClarinAutoRegistrationController * Added docs for the ClarinVerificationTokenConverter * Added docs for the ClarinVerificationTokenResource, ClarinVerificationTokenRest, ClarinVerificationTokenRestRepository * Removed changes from the upstream classes * Added doc to the ClarinShibbolethLoginFilter * Fixed ClarinShibbolethLoginFilter the case when the IdP hasn't sent netid and the user was registered. * Fixed ShibbolethLoginFilterIT test failures. The tests was copied to the ClarinShibbolethLoginFilter. * Fixed AuthenticationRestControllerIT failing test * Fixed checkstyle issues * Added license headers. * Fixed removed allowed headers - I removed them accidentally Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/laf-1-ref-box (#179) * Initial commit * Created Controller for FeaturedServices * Created Controller for getting xml data as string from the OAI * Fixed error because of empty dspace.entity.type metadata field - it throws oai error * Added docs and fixed checkstyle issues. * Manually destroyed created eperson in IT. * Fixed unexpected checkstyle issue * Delete created Eperson in the test `userFillInEmailAndShouldBeRegisteredByVerificationToken` Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/aai-1-federated-sso-groups (#170) the user is added to the group after Shibboleth login * Initial commit * Send the email to the user with autoregistration link. * Created verification token table and authorization the user by that token. * Created Clarin classes for custom Shibboleth authentication. * Created clarin verification token REST, Repository, Converter * Added log error message * The user is automatically logged in after Shibboleth authentication. * The user is authenticated in the filter if the IDP has sent all headers without email and eperson exist in the table. * Revert changes in the ShibAuthentication class * Added docs to the ClarinShibAuthentication * Added docs to the ShibHeaders, ShibAuthentication, Headers, ClarinVerificationToken * Added doc to the ClarinVerificationTokenService * Added doc to the ClarinVerificationTokenServiceImpl * Added doc to the ClarinVerificationTokenDAO and ClarinVerificationTokenDAOImpl * Added docs for the ShibHeadersTest * Added docs for the ClarinAutoRegistrationController * Added docs for the ClarinVerificationTokenConverter * Added docs for the ClarinVerificationTokenResource, ClarinVerificationTokenRest, ClarinVerificationTokenRestRepository * Removed changes from the upstream classes * Added doc to the ClarinShibbolethLoginFilter * Fixed ClarinShibbolethLoginFilter the case when the IdP hasn't sent netid and the user was registered. * Fixed ShibbolethLoginFilterIT test failures. The tests was copied to the ClarinShibbolethLoginFilter. * Fixed AuthenticationRestControllerIT failing test * Fixed checkstyle issues * Added license headers. * Initial commit * temp commit * The user is assigned to the group based on the configuration. * Refactoring following the checkstyle requirements * Fixed failing test * Revert changed allowed headers * Solved conflicts Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/stat-1-create-api-track-events (#182) track the statistics - bitstream and oai harvesting * Initial commit * Added scripts for running the matomo with database and phpadmin * The Matomo Tracker added to the DSpace project. * Temporary commit * The statistics are sent to the Matomo with set paramaters * Created OAI Matomo Tracker * Added docs for the new classes * Little bit of refactoring and adding the docs * Fixed checkstyle issues * Trying to fix the test by deleting the User Registration record. * Fixed checkstyle violation Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * internal/add-bibtex-crosswalk (#183) * added bibtex format and support java functions * fix for PR * added author lines * Add property for the cache-server (#189) cache-server cfg property Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * Update core-services.xml (#191) Changed Matomo tracker URL to `http://dev-5.pc:8135/matomo.php` Changed Matomo tracker URL to `http://dev-5.pc:8135/matomo.php` * Updated yml for matomo docker compose * Changed Matomo Tracker Auth Token * feature/laf-2-oai-update-after-db-change (#184) create, delete, update item * solr reindex implemented * fix for PR * fix * try fix * nondelete * Throwing the Runtime Error during deleting or reindexing the Item was changed to logging an error. * Fixed checkstyle issue. * Do not throw Runtime Exception in the test --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * feature/lf-4-import-license (#186) with python api * Initial commit * Added some ClarinLicense classes * Added some ClarinLicense classes * Added some ClarinLicense classes * Created ClarinLicenseLabelList and other classes. It throws ClassNotFound exception * Clarin License has ClarinLicenseLabel classes in the response * Return the clarinLicense with extended labels and another custom data * Return the clarinLicense with extended labels and another custom data * Created findAll method in the ClarinLicenseLabelRestRepository * Cannot map HashMap to the ClarinLicenseRest * Created Endpoint and test for defining a new clarin license * Created Endpoint and tests for Deleting the Clarin Licenses * Created endpoint for updating licenses with tests * Created endpoint for creating Clarin License Labels with tests * Added docs * fixed checkstyle violations * Feature/lf 4 license administrator-2-dtq-dev-tmp (#150) * Initial commit * Added some ClarinLicense classes * Added some ClarinLicense classes * Added some ClarinLicense classes * Created ClarinLicenseLabelList and other classes. It throws ClassNotFound exception * Clarin License has ClarinLicenseLabel classes in the response * Return the clarinLicense with extended labels and another custom data * Return the clarinLicense with extended labels and another custom data * Created findAll method in the ClarinLicenseLabelRestRepository * Cannot map HashMap to the ClarinLicenseRest * Created Endpoint and test for defining a new clarin license * Created Endpoint and tests for Deleting the Clarin Licenses * Created endpoint for updating licenses with tests * Created endpoint for creating Clarin License Labels with tests * Added docs * fixed checkstyle violations Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * added license header * feature/lf-4 license-admin-another-tables created the resource mapping and make counting license bitstreams * created clarin license resource mapping * error with integration tests - active transaction * checkout from license administrator * tests not working * checkout with feature/lf-4-license-administrator * The bitstream is mapped to the license * The bitstream is mapped to the license in the IT too * a little refactoring Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * fixed checkstyle violations and added header to the new classes * feature/lf-4-license-admin-fixed-null-error * init commit * mapping new tables * Fixed clarin null bitstream exception * Commented new table classes * Added license headers * Fixed checkstyle violation * Fixed external handle rest repository IT failing tests - created HandleClarinBuilder * Fixed checkstyle violations Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * controller for license imports * tests for import licenses * test for extended mapping json * tests for all * errors in tests * test work * test errors * license import works * grammer * import licenses * missing atribut created on * import licenses done * checkstyle * resolved conflicts * clean licenses after test * checkstyle * remove == null * Fixed checkstyle issues * fixed wrong if condition to do not create license if not exists * review correction * remove eperson_id --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> * feature/laf-4-item-new-version (#177) new version of the Item has special handle * Initial commit * Initial commit * Created test to create an item with a new version. * The item handles are managed into the items metadata: dc.relation.replaces and dc.replation.isreplacedby * Fixed error: after creating a new version more time the dc.relation.replaces was added there multiple times * Fixed checkstyle issues and added license headers. * Fixed failing tests * Fixed commented code and added docs * Fixing spacing changes * Fixing spacing changes * Update spring-dspace-core-services.xml Added the comments for explaining why is some rows commented out --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * Customize CLARIN-DSpace search facets. (#203) * Added Community indexation * Fixed checkstyle violation * Add license header check and update signature * Added doc --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * Changed files to update DSPace to version 7.2.1 (#205) updated pom.xml files. * Changed files to update DSPace to version 7.2.1 * Added deleted changes. * Refactoring --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * Internal discoveryrestcontrollerit tests are failing (#208) dateIssued facet was removed * Fixed DiscoveryRestControllerIT tests - dateIssued was doing the problems. * Created ClarinDiscoverySearchFilterIT --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * internal/fixed-tracking-of-the-Solr-statistics. (#199) pulled code from vanilla * Fixed tracking of the Solr statistics. * Fixed checkstyle violations --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * fixing-review-errors-1 (#211) ACL - component annotation, wrong issue condition * Removed @Component annotation from the ACL class and fixed wrong if condition in the `ItemImportServiceImpl`. * Removed unused import - checkstyle issue. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * fixed granting of the license Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * internal/missing-sending-of-email-with-token (#213) * Added sending an email with download link. * Fixed checkstyle issues and failing integration tests. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * expose port for remote debugging * updated scripts for debug access * added execution permission * modified debug checking and starting * forgotten file for custom run * forgotten permissions as well * removal of useless comment * Updated database model following the new requirements from migration. (#226) Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * migration2clarin7/notice-step-is-missing (#231) * Added a new empty notice step. * Configured collection with specific step. * Fixed checkstyle issues. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * migrate2clarin7/authors-name-surname-autocomplete (#235) * Changed input type to `name` it divides the author one input field to two input fields. * Created input type `clarin-name` * Working on fixing the MetadataValueRestRepository - it returns a lot of suggestions if the Item contains searched value * Created test to check if the error is fixed. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * migration2clarin7/fix different separator in crosswalks and added metasharev2 crosswalk. (#223) * Added missing metasharev2 crosswalk into xoai.xml - without it, this crosswalk would never be used. * Added a new metadata formats for the `metashare2.xsl` crosswalk * Working on separator and trying to fix metashare crosswalk * Created scripts for fast updating the crosswalks without rebuilding and installing the dspace project. * Added fast building script for oai-pmh package * Added fast building script for dspace-api package * str:split function replaced by the tokenize function. * Fixed creating NodeList * Refactoring * Added script for updating the configuration files * Refactoring and fixed checkstyle violations * `registry.metadata.load = metashare-schema.xml` property cannot be added in the `clarin-dspace.cfg` because then some Unit tests are failing.. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * 70-BE/license-page-missing-pagination-sorting (#250) * Added a new searching endpoint into ClarinLicenseRestRepository to find Clarin License by substring of it's name * Fixed checkstyle issue --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * 64-BE/user could see withdrawn items copied some code from vanilla (#252) * Added withdraw and discoverable option into search defaultFilterQueries into discovery.xml * Copied fix code from the vanilla DSpace. * Added a new itemtype search filter. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * Added doc (#260) Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * 93BE/hide-some-metadata-fields-from-full-item-page (#258) * Hide `local.submission.note` metadata field form the full item page. * Updated ItemConverter and MetadataExposureService to show hidden metadata values for the submitter. Also fixed showing all licenses for every user, not only for the admin. * Submitter cannot see metadata fields which could see only admin. * Updated the integration test --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * internal/migrate-clarin-dspace5-to-clarin-dspace7-continue (#220) * export table data as json * controller for group import * upgrade values type in database * alter table * controller for group2group import * controller for group2eperson * Removed varchar limitations (#218) Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * create new cntroller for item and service for workspaceitem * changed Controller from ItemRest to WorkspaceRest * added test * fix error in controller * create workflowitem from workspaceitem * problem with adding submitter and creating workflowitem * import workflowitem and item * fix incorrect class in log' * 'reate bitstream without file, error with protected consturctor * test for create bundle for existing file * missing committed xml file * fix errors for bitstream validation * correction of the test errors * added primary bitstream to bitstream * test for import items * fix item tests - inArchive * fix import item tests * correction of found errors * controller for import eperson and user_registration * import logo of collection and community * modified bitstream import and added most_recent_checksum import * fix specifically date format * added test for import logo * new builder for bitstream without item and bundle, fix test errors * checkstyle and comments * fix tests * checkstyle and fix test * fix failed test * Fixed review issues. * 74-BE license definition missing attribute values * Fixed review requests. * Removed unnecessary files --------- Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * 96-BE/update-readme-with-issues (#264) * Updated README-dtq.md * Updated README-dtq.md with not imported and missing tables --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * internal-BE/fix-failing-integration-tests (#268) * Added ClarinItemTypeFilterMatcher * Fixed IT * Added a new Browse matchers for updated browse searching. * Fixed removed tests * Fixed removed tests * Fixed removed tests * Fixed removed tests --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * 102-BE/cannot-read-big-file-by-readAllBytes (#277) * replace readAllBytes * fix test errors * 103-be/shibboleth-login-wrong-error-page (#279) * The user is redireced to the FE after wrong shibboleth authentication. * Changed redirect URLs * Fixed checkstyle issues * Copied ShibbolethFilterIT into ClarinShibbolethFilterIT because the tests did must be updated. * 105-be/user-is-not-registered-after-shibboleth-login (#281) * firstname and lastname is not required for proper Shibboleth login. * Fixed IT to be failed if code is wrong * 88-BE/license-labels-are-missing-icons (#273) * License label icon can be null * user rest repository for license import * Fixed checkstyle issues * Fixed failing IT --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> * 110-be/imported-item-should-not-regenerate-certain-metadata-fields (#284) * Created test which fail when issue happens * Some metadata values are not updated during the import. * Changed logging (#286) * 116 be/deleted bitstreams cannot be imported (#296) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 80-BE/import-tasklistitem (#300) * create method and test * test runs * condition of membership * throw exception soon and explain better (#308) * added commit (#306) * 87-BE/adding-missing-attributes (#303) * add welcome_info and can_edit_submission_metadata * added missing attributes to the database * errors from review * 119-BE/remove-validation-of-deleted-bitstreams (#302) * remove validation control for deleted bitstream * added log * fix review comments * added mvn argument fail-at-end (#319) * added mvn argument fail-at-end * see mvn version * see maven version * -fae * final version of build.yml * 75-BE/missing-handles (#314) * create handle without dspace object * new controller for import handle without dspace object * create handle for workspaceitem * using of existing handle if it exists (#316) * checkstyle * fix failed test * added whitespace after for * review * removed authorization for handle creation * remove unneeded import * checkstyle * 122-be/restricted-item-download-issues (#331) * Initial commit * Remove the error when the ClarinLicense doesn't require any additional user metadata and the file cannot be downloaded because the user didn't fill in any user metadata. * The user cannot download the item with ClarinLicense that doesn't require user metadata, but controller methods required this information. * Be/fixed bitstreams added user metadata (#295) * 116-be/deleted-bitstreams-cannot-be-imported (#291) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> * 76-BE/import-user-metadata (#294) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * 76-BE/import-user-metadata-with-fixed-bitstream (#307) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * fix import user_metadata * fix mishmash with eperson_id and user_registration_id * create user registration and eperson separatelly, checkstyle * edited import user metadata * checkstyle --------- Co-authored-by: Michaela Paurikova <michaela.paurikova@dataquest.sk> Co-authored-by: Paurikova2 <107862249+Paurikova2@users.noreply.github.com> * Removed not defined search options. (#337) * browse - Updated IT according to updated cfg (#339) * Removed not defined search options. * Updated IT according to a cfg updates. * add redeploy to dev-5 -> curl call to deploy action * correct redeploy branch in github action * trigger docker images on correct branch * disable dspace v 7.2 on dev-5 * Upgrade CLARIN-DSpace to 7.5 (#344) * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wron…

MajoBerger and others added 15 commits June 5, 2023 06:35

trying action with different ref

190c90b

fixed checkstyle

b683b0d

Merge branch 'internal/fix-integration-tests-75' of github.com:dataqu…

fd5cc82

…est-dev/DSpace into internal/fix-integration-tests-75

updated config, fixed several integration tests

e311ef7

removed old zip file

1479fa1

assurance

0156732

Merge branch 'migrate-to-7.5' into internal/fix-integration-tests-75

0bd124c

dspace.ui.url was changed to http://localhost:4000

9e1715f

Update build.yml

12064b7

Added -fae to integration tests

Merge branch 'migrate-to-7.5' into internal/fix-integration-tests-75

982cc59

Removed unnecessary check

174b8f3

Merge remote-tracking branch 'origin/internal/fix-integration-tests-7…

d159320

…5' into internal/fix-integration-tests-75

Revert to DEFAULT_AMOUNT_FORMATS=81

625957e

Fixed lookupPubmed test

6f04a0b

milanmajchrak merged commit 41d5a1a into migrate-to-7.5 Jun 22, 2023

milanmajchrak mentioned this pull request Aug 7, 2023

tul/merge-into-clarin-dspace #402

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internal/fix integration tests 75 #311

Internal/fix integration tests 75 #311

MajoBerger commented Jun 7, 2023

Internal/fix integration tests 75 #311

Internal/fix integration tests 75 #311

Conversation

MajoBerger commented Jun 7, 2023

Problem description

Reported issues

Not-reported issues

Analysis

Problems