test for bitstream with null value for sizebytes #774
Merged
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 3, 2024
Paurikova2
requested review from
vidiecan and
milanmajchrak
and removed request for
vidiecan
milanmajchrak
requested changes
Oct 8, 2024
dspace-server-webapp/src/main/java/org/dspace/app/rest/ClarinBitstreamImportController.java
Outdated
Show resolved
Hide resolved
milanmajchrak
approved these changes
Oct 8, 2024
vidiecan
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
During Ondrej's bitstream import, two bitstreams were not imported.
1. Problem: Backend logs didn't help.
Solution: Fixed exception message in logs.
2. Problem: The byte_size of this bitstream is null. We tried inserting a null value into a long type
Solution: Checked if inserted value is notNull.
3. Problem: add warning about importing bitstream which is already deleted to pump
Warning
Since we cannot add null to the long type, the imported values of sizebytes, sequence_id and bitstream_format are not null, but predefined values (sizebytes = 0, sequence_id = -1, bitstream_format = "Unknown").