Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default starting IP should be 127.0.0.1 #71

Closed
tolbertam opened this issue Feb 14, 2019 · 0 comments
Closed

Default starting IP should be 127.0.0.1 #71

tolbertam opened this issue Feb 14, 2019 · 0 comments
Milestone
0.8.8

Comments

@tolbertam
Copy link
Contributor

For some reason the default starting ip address is 127.0.1.1. I think this might be to prevent conflicting with a local C* running, but for usability, especially on OS X, we should default to 127.0.0.1:

simulacron/native-server/src/main/java/com/datastax/oss/simulacron/server/AddressResolver.java

Line 25 in eaa9991

byte[] defaultStartingIp = new byte[] {127, 0, 1, 1};

@tolbertam tolbertam added this to the 0.8.8 milestone Mar 6, 2019
tolbertam added a commit that referenced this issue Mar 6, 2019
@tolbertam
[#71] Default starting IP should be 127.0.0.1
0a84998 
For some reason the default starting ip address was 127.0.1.1.

This might have been to prevent conflicting with a local C* running,
but for usability, especially on OS X, we should default to 127.0.0.1.

The standalone jar defaults to 127.0.0.1, so this makes using native
server directly consistent with the web-based mode.
@tolbertam tolbertam mentioned this issue Mar 6, 2019
Merged
tolbertam added a commit that referenced this issue Mar 6, 2019
@tolbertam
[#71] Default starting IP should be 127.0.0.1 (#73)
17549aa 
For some reason the default starting ip address was 127.0.1.1.

This might have been to prevent conflicting with a local C* running,
but for usability, especially on OS X, we should default to 127.0.0.1.

The standalone jar defaults to 127.0.0.1, so this makes using native
server directly consistent with the web-based mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.8
Development

No branches or pull requests
1 participant
@tolbertam