[#82] Update PeerMetadataHandler to support new cluster name query #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change below: apache/cassandra-java-driver@85f2ced#diff-8dd2643235bd91722e75bdd299d4ca8c Was released in drivers OSS 3.7.2 and DSE 1.8.2. We need to update `PeerMetadataHandler` accordingly.
mikefero
approved these changes
Sep 23, 2019
| private static final String queryClusterName = "select cluster_name from system.local"; | ||
| private static final Pattern queryClusterName = | ||
| Pattern.compile( | ||
| "select cluster_name from system.local( where key='local')?", Pattern.CASE_INSENSITIVE); |
There was a problem hiding this comment.
nit: select cluster_name from system.local( where key='local')? => SELECT cluster_name FROM system.local( WHERE key='local')?
Just going for consistency with other CQL patterns (even though it looks like this one slipped through before).
There was a problem hiding this comment.
The queries here try to stick as close as possible to what the DS Java driver actually sends, and indeed, oddly enough, the driver usually sends SELECT but for the cluster name, it's select. But I agree with you, now that I turned the patterns case-insensitive we can safely harmonize everything and use SELECT consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change below:
apache/cassandra-java-driver@85f2ced#diff-8dd2643235bd91722e75bdd299d4ca8c
Was released in drivers OSS 3.7.2 and DSE 1.8.2. We need to update
PeerMetadataHandleraccordingly.