Add tokenizers_srcdir_relative build tag to allow static library path #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daulet
reviewed
Nov 30, 2023
| @@ -3,7 +3,8 @@ package tokenizers | |||
| // TODO packaging: how do we build the rust lib for distribution? | |||
|
|
|||
| /* | |||
| #cgo LDFLAGS: ${SRCDIR}/libtokenizers.a -ldl -lm -lstdc++ | |||
| #cgo tokenizers_srcdir_relative LDFLAGS: ${SRCDIR}/libtokenizers.a -ldl -lm -lstdc++ | |||
| #cgo !tokenizers_srcdir_relative LDFLAGS: /usr/lib/libtokenizers.a -ldl -lm -lstdc++ | |||
There was a problem hiding this comment.
why are you picking /usr/lib/libtokenizers.a over package relative libtokenizers.a?
There was a problem hiding this comment.
I mentioned that in my comment, by making the build flag name "tokenizers_srcdir_relative" as you suggest, package relative therefore becomes the non-default option. If you prefer to keep the current default behaviour we need to change that flag name to something like "tokenizers_srcdir_static"? Do you have a preferred name?
|
I think #18 solves this issue too. |
|
I believe #18 solves this more generically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tokenizers_srcdir_relative build tag to allow library to be placed either in the module source directory, or in the static /usr/lib/ path.
Due to the suggested naming of the variable, I have therefore made the relative path option non-default. If you would prefer the current behaviour to be unchanged, should we instead make the tag tokenizers_srcdir_static or something?