feat: add option to retrieve offsets from tokenizer #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daulet
reviewed
Jul 19, 2024
daulet
reviewed
Jul 19, 2024
daulet
reviewed
Aug 4, 2024
daulet
previously approved these changes
Aug 4, 2024
|
@riccardopinosio PTAL at the test failure in CI |
|
@daulet I reverted the change that added the freeing of the offset array memory, bazel didn't like it because memory was being freed twice. I believe the offsets get freed when the buffer itself is freed using |
daulet
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the possibility to return the Offsets as a tokenizer option, could you take a look?
We use offsets in https://github.com/knights-analytics/hugot for the token classification pipeline.