Updates #73
Merged
Updates #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exelord
force-pushed
the
feature-updates
branch
from
dbdabe5
to
cb66f9b
Compare
Exelord
force-pushed
the
feature-updates
branch
from
cb66f9b
to
725969e
Compare
Exelord
force-pushed
the
feature-updates
branch
from
3698527
to
ab64508
Compare
Exelord
force-pushed
the
feature-updates
branch
from
ab64508
to
bebab71
Compare
davewasmer
reviewed
Sep 4, 2018
index.js
Outdated
|
|
||
| treeForPublic(tree) { | ||
| let faviconTree = new Favicons(this.parentOptions.trees.public, this.parentOptions.favicons); | ||
| return mergeTrees([ faviconTree, tree ].filter((v) => v), { overwrite: true }); |
There was a problem hiding this comment.
One nice little take on .filter((v) => v) is .filter(Boolean) instead. It's a little more explicit and concise. But if you prefer this syntax, don't bother changing. Just throwing that out there.
There was a problem hiding this comment.
Wow cool thing I didn't know that's possible. :)
davewasmer
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update packages to latest versions as well as fix deprecations and issue with specifying custom callback by the app.