Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery version expects object to be passed in. #91

Closed
adaptifyDesigns opened this issue Sep 3, 2014 · 3 comments
Closed

jQuery version expects object to be passed in. #91

adaptifyDesigns opened this issue Sep 3, 2014 · 3 comments
Labels

Comments

@adaptifyDesigns
Copy link

@davidjbradshaw I've been trying to get your script to work with my project, but haven't been successful.

You can view my attempt here: http://phoogoodev.com/ellison/store

If you inspect the element or view source, you'll see that I've linked to the proper files on both the host page (in the footer) as well as on the content page (you'll find the iframeResizer.contentWindow.min.js file linked to in #header > #header-wrap > #mobile-nav-wrap > .header-search > FORM ... this is the only place I was able to insert any custom code).

I've tried only setting the width attribute of the iframe to 100% and leaving out the height attribute as your documentation demonstrates, but this did not work. So then I tried adding a height attribute and also adding a style attribute with min-height: 600px; but neither of those approaches worked.

I also tried changing the heightCalculationMethod option to bodyScroll but that also did not solve anything.

Am I using your plugin incorrectly? There are quite a few errors in the console, but none of them refer to any of the iframe-resizer files or tasks, so I'm not sure where to start troubleshooting. Please let me know how I should proceed.

Thank you in advance for your help!

@adaptifyDesigns
Copy link
Author

Hi again, sorry for the false alarm, but I fixed it. My jQuery syntax was wrong I guess.
I changed it from this:

$('#InkSoft_iFrame').iFrameResize();

to this:

$('#InkSoft_iFrame').iFrameResize({ });

Now it's working!

@davidjbradshaw
Copy link
Owner

I consider that a bug, both forms should work.

@davidjbradshaw davidjbradshaw reopened this Sep 3, 2014
@davidjbradshaw davidjbradshaw changed the title autoResize not working at all. jQuery version expects object to be passed in. Sep 3, 2014
@davidjbradshaw
Copy link
Owner

Fixed in v2.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants