adding support of array for checkOrigin parameter of iframeResizer #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Why did you close this? Is there a problem with it? Could you remove the .min.js and .map file please. It will make it easier to merge that way. Thanks, |
|
I noticed that there are some problems with tests. I'll check why tests are failing and will ask for another pull request without .min.js and .map files. |
|
Ok cool. |
|
Hey just wondering how your getting on with this, as had another Pull Request and would like to bundle them into one release if possible. |
|
Hi David, Cheers, Andrej |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is pull request for the adding support of domain arrays in checkOrigin parameter discussed on #199
Adding also *.min.js and *.map artefacts from grunt. Please discard them if not relevant.