Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iframeHeight and iframeWidth properties to pageInfo #314

Merged
merged 2 commits into from
Feb 23, 2016
Merged

Add iframeHeight and iframeWidth properties to pageInfo #314

merged 2 commits into from
Feb 23, 2016

Conversation

pomartel
Copy link
Contributor

@pomartel pomartel commented Feb 3, 2016

I had originally contributed to adding the pageInfo object to iframe-resizer. It turns out that in most case, you also need to know the height of the iframe to properly calculate absolute position of overlays in the iframe. Therefore I added iframeHeight and iframeWidth to the mix.

@davidjbradshaw
Copy link
Owner

Sounds good, super busy atm. Will try and take a look in the next couple of
weeks.

Thanks,
D.

On Wed, Feb 3, 2016 at 8:11 PM, Pierre Olivier Martel <
notifications@github.com> wrote:

I had originally contributed to adding the pageInfo object to
iframe-resizer. It turns out that in most case, you also need to know the
height of the iframe to properly calculate absolute position of overlays in

the iframe. Therefore I added iframeHeight and iframeWidth to the mix.

You can view, comment on, or merge this pull request online at:

#314
Commit Summary

  • Added iframeHeight and iframeWidth properties to pageInfo
  • Typo fix

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#314.

David J. Bradshaw )'( dave@bradshaw.net

'The people we think are a little weird are the ones who change the world'

  • Simon Sinek

@davidjbradshaw davidjbradshaw merged commit 981b515 into davidjbradshaw:master Feb 23, 2016
@davidjbradshaw
Copy link
Owner

Thanks and sorry for the delay. Released in v3.5.2

@pomartel
Copy link
Contributor Author

Awesome! Thanks for the follow-up David.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pomartel @davidjbradshaw