[ML] Use correct writable name for model assignment metadata in mixed…

… cluster (elastic#100886) Older nodes will fail if they do not recognise the named writable
davidkyle · Oct 16, 2023 · 310d44d · 310d44d
1 parent 949923b
commit 310d44d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/docs/changelog/100886.yaml b/docs/changelog/100886.yaml
@@ -0,0 +1,5 @@
+pr: 100886
+summary: Use the correct writable name for model assignment metadata in mixed version clusters. Prevents a node failure due to IllegalArgumentException Unknown NamedWriteable [trained_model_assignment]
+area: Machine Learning
+type: bug
+issues: []
diff --git a/.../java/org/elasticsearch/xpack/ml/inference/assignment/TrainedModelAssignmentMetadata.java b/.../java/org/elasticsearch/xpack/ml/inference/assignment/TrainedModelAssignmentMetadata.java
@@ -309,7 +309,8 @@ private TrainedModeAssignmentDiff(final StreamInput in, String writeableName) th
         @Override
         public Metadata.Custom apply(Metadata.Custom part) {
             return new TrainedModelAssignmentMetadata(
-                new TreeMap<>(modelRoutingEntries.apply(((TrainedModelAssignmentMetadata) part).deploymentRoutingEntries))
+                new TreeMap<>(modelRoutingEntries.apply(((TrainedModelAssignmentMetadata) part).deploymentRoutingEntries)),
+                writeableName
             );
         }