Start waiting for container exit on container start instead of end of…

… attach Workaround to the issue loosely described in apocas/dockerode#534
davidreis97 · Mar 19, 2020 · 1cbc6a2 · 1cbc6a2
1 parent cbaa725
commit 1cbc6a2
Showing 1 changed file with 19 additions and 20 deletions.
diff --git a/dockerfile-utils/src/dynamicAnalysis.ts b/dockerfile-utils/src/dynamicAnalysis.ts
@@ -185,9 +185,26 @@ export class DynamicAnalysis {
 				this.getPerformance();
 				this.getOS();
 				this.checkEnvVar();
+
+				container.wait((err, data) => {
+					this.sendProgress(true);
+					if (this.isDestroyed) {
+						return;
+					}
+					if (err) {
+						this.debugLog("ERROR GETTING CONTAINER EXIT CODE", err);
+						return;
+					}
+					this.log("CONTAINER CLOSED WITH CODE", data.StatusCode);
+					if (data.StatusCode != 0) {
+						this.addDiagnostic(DiagnosticSeverity.Error, this.dockerfile.getENTRYPOINTs()[0].getRange(), "Container Exited with code (" + data.StatusCode + ") - See Logs");
+						this.publishDiagnostics();
+					}
+					this.destroy();
+				});
 			});
 
-			container.attach({ stream: true, stdout: true, stderr: true }, (err, stream: Stream) => {
+			container.attach({stream: true, stdout: true, stderr: true}, (err, stream: Stream) => {
 				if (this.isDestroyed) {
 					this.sendProgress(true);
 					return;
@@ -199,25 +216,7 @@ export class DynamicAnalysis {
 					this.sendProgress(true);
 				}
 				stream.on('data', (data) => {
-					this.log("CONTAINER STDOUT", data);
-				});
-				stream.on('end', (_) => {
-					container.wait((err, data) => {
-						this.sendProgress(true);
-						if (this.isDestroyed) {
-							return;
-						}
-						if (err) {
-							this.debugLog("ERROR GETTING CONTAINER EXIT CODE", err);
-							return;
-						}
-						this.log("CONTAINER CLOSED WITH CODE", data.StatusCode);
-						if (data.StatusCode != 0) {
-							this.addDiagnostic(DiagnosticSeverity.Error, this.dockerfile.getENTRYPOINTs()[0].getRange(), "Container Exited with code (" + data.StatusCode + ") - See Logs");
-							this.publishDiagnostics();
-						}
-						this.destroy();
-					});
+					this.log(data);
 				});
 			});
 		});